From e14fc01e6e999bebad3f1fafa9c6fd7ee3b3accb Mon Sep 17 00:00:00 2001 From: "v-yuzhichen@microsoft.com" Date: Mon, 6 Jun 2022 17:43:11 +0800 Subject: [PATCH 1/2] Fix Az.Compute XML Comments --- .../Common/AzureContextAdapterExtensions.cs | 2 ++ .../Compute/Common/DiagnosticsHelper.cs | 2 ++ .../AzureVMBackupExtensionUtil.cs | 19 +++++-------------- .../VirtualHardDiskSettingData.cs | 1 + 4 files changed, 10 insertions(+), 14 deletions(-) diff --git a/src/Compute/Compute/Common/AzureContextAdapterExtensions.cs b/src/Compute/Compute/Common/AzureContextAdapterExtensions.cs index b4fad370212d..ca885ed56607 100644 --- a/src/Compute/Compute/Common/AzureContextAdapterExtensions.cs +++ b/src/Compute/Compute/Common/AzureContextAdapterExtensions.cs @@ -29,6 +29,7 @@ public static class AzureContextAdapterExtensions /// Get the current storage account. /// /// The current Azure context. + /// /// The current storage account, or null, if no current storage account is set. public static CloudStorageAccount GetCurrentStorageAccount(this IAzureContext context, IStorageServiceProvider provider) { @@ -92,6 +93,7 @@ public static IStorageContext GetStorageContext(this IStorageService service) /// /// The storage service provider to retrieve storage service details /// The storage accoutn name + /// /// A CloudStorageAccount client for storage data plane tasks public static CloudStorageAccount GetCloudStorageAccount(this IStorageServiceProvider provider, string accountName, string resourceGroupName = null) { diff --git a/src/Compute/Compute/Common/DiagnosticsHelper.cs b/src/Compute/Compute/Common/DiagnosticsHelper.cs index 10cae96bc633..acabd01afc48 100644 --- a/src/Compute/Compute/Common/DiagnosticsHelper.cs +++ b/src/Compute/Compute/Common/DiagnosticsHelper.cs @@ -661,6 +661,8 @@ private static string GetEndpointFromStorageContext(IStorageContext context) /// /// Public configuration file path /// Private configuration file path, can be empty + /// + /// /// Storage client /// A tuple with public configuration as first element and private configuration as second element public static Tuple GetConfigurationsFromFiles(string publicConfigPath, string privateConfigPath, string resourceId, Cmdlet cmdlet, IStorageManagementClient storageClient) diff --git a/src/Compute/Compute/Extension/AzureVMBackup/AzureVMBackupExtensionUtil.cs b/src/Compute/Compute/Extension/AzureVMBackup/AzureVMBackupExtensionUtil.cs index 35763c093e1b..ca741a033cf8 100644 --- a/src/Compute/Compute/Extension/AzureVMBackup/AzureVMBackupExtensionUtil.cs +++ b/src/Compute/Compute/Extension/AzureVMBackup/AzureVMBackupExtensionUtil.cs @@ -73,10 +73,10 @@ private string GetBase64Encoding(object obj) /// /// find the snapshot with the tags /// + /// /// - /// - /// /// + /// /// public List FindSnapshot(IAzureContext azContext, List blobUris, List storageCredentialsFactory, Dictionary snapshotQuery) { @@ -178,13 +178,8 @@ public AzureVMBackupBlobSasUris GenerateBlobSasUris(List blobUris, IAzur /// /// remove the vmbackups with the metadata key "vmbackuptag" and value snapshotTag, snapshotTag is the parameter passed in. /// - /// - /// - /// - /// - /// - /// - /// + /// + /// /// public void RemoveSnapshot(AzureVMBackupConfig vmConfig, string snapshotTag, VirtualMachineExtensionBaseCmdlet virtualMachineExtensionBaseCmdlet) { @@ -216,11 +211,7 @@ public void RemoveSnapshot(AzureVMBackupConfig vmConfig, string snapshotTag, Vir /// /// we only support the Linux box now, if it's a windows, one AzureVMBackupException would be thrown. /// - /// - /// - /// - /// - /// + /// /// /// public void CreateSnapshotForDisks(AzureVMBackupConfig vmConfig, string snapshotTag, VirtualMachineExtensionBaseCmdlet virtualMachineExtensionBaseCmdlet) diff --git a/src/Compute/Compute/StorageServices/VirtualHardDiskSettingData.cs b/src/Compute/Compute/StorageServices/VirtualHardDiskSettingData.cs index 349259890f6f..7f54cb47b5bf 100644 --- a/src/Compute/Compute/StorageServices/VirtualHardDiskSettingData.cs +++ b/src/Compute/Compute/StorageServices/VirtualHardDiskSettingData.cs @@ -83,6 +83,7 @@ public class VirtualHardDiskSettingData /// /// The block size of the virtual hard disk. /// The logical sector size of the virtual hard disk. + /// /// The physical sector size of the virtual hard disk. /// public From 545317552327a18da57b3c02bbbaa0be2909bbe6 Mon Sep 17 00:00:00 2001 From: "v-yuzhichen@microsoft.com" Date: Tue, 7 Jun 2022 17:56:04 +0800 Subject: [PATCH 2/2] Fix Az.Compute.Helpers XML Comments --- .../Compute.Helpers/Storage/Models/BlobInventoryPolicy.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Compute/Compute.Helpers/Storage/Models/BlobInventoryPolicy.cs b/src/Compute/Compute.Helpers/Storage/Models/BlobInventoryPolicy.cs index a4225df4adaa..997938da2f40 100644 --- a/src/Compute/Compute.Helpers/Storage/Models/BlobInventoryPolicy.cs +++ b/src/Compute/Compute.Helpers/Storage/Models/BlobInventoryPolicy.cs @@ -43,6 +43,7 @@ public BlobInventoryPolicy() /// "Microsoft.Storage/storageAccounts" /// Returns the last modified date and /// time of the blob inventory policy. + /// public BlobInventoryPolicy(BlobInventoryPolicySchema policy, string id = default(string), string name = default(string), string type = default(string), System.DateTime? lastModifiedTime = default(System.DateTime?), SystemData systemData = default(SystemData)) : base(id, name, type) {