From 3cbc836842f8f9ea394fe837f6a523159ac907f2 Mon Sep 17 00:00:00 2001 From: Alfredo Santamaria Gomez Date: Wed, 2 Dec 2020 15:12:19 -0800 Subject: [PATCH 1/2] Add node type before vmss --- src/ServiceFabric/ServiceFabric/ChangeLog.md | 1 + .../ServiceFabric/Commands/AddAzureRmServiceFabricNodeType.cs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ServiceFabric/ServiceFabric/ChangeLog.md b/src/ServiceFabric/ServiceFabric/ChangeLog.md index 72c449fa3208..5fdc779dc59b 100644 --- a/src/ServiceFabric/ServiceFabric/ChangeLog.md +++ b/src/ServiceFabric/ServiceFabric/ChangeLog.md @@ -22,6 +22,7 @@ * Add example to Set-AzServiceFabricSetting with SettingsSectionDescription param * Update application related cmdlets to call out that support is only for ARM deployed resources * Mark for deprecation cluster cert cmdlets Add-AzureRmServiceFabricClusterCertificate and Remove-AzureRmServiceFabricClusterCertificate +* Fix add-AzServiceFabricNodeType. Add node type to service fabric cluster before creating virtual machine scale set. ## Version 2.2.0 diff --git a/src/ServiceFabric/ServiceFabric/Commands/AddAzureRmServiceFabricNodeType.cs b/src/ServiceFabric/ServiceFabric/Commands/AddAzureRmServiceFabricNodeType.cs index f518cab019e3..2833c6196051 100644 --- a/src/ServiceFabric/ServiceFabric/Commands/AddAzureRmServiceFabricNodeType.cs +++ b/src/ServiceFabric/ServiceFabric/Commands/AddAzureRmServiceFabricNodeType.cs @@ -124,8 +124,8 @@ public override void ExecuteCmdlet() { var cluster = GetCurrentCluster(); this.diagnosticsStorageName = cluster.DiagnosticsStorageAccountConfig.StorageAccountName; - CreateVmss(cluster.ClusterId); var pscluster = AddNodeTypeToSfrp(cluster); + CreateVmss(cluster.ClusterId); WriteObject(pscluster, true); } } From 3ccfe42fdede390d181a2cccb79ffae0707d7575 Mon Sep 17 00:00:00 2001 From: Alfredo Santamaria Gomez Date: Wed, 2 Dec 2020 15:16:11 -0800 Subject: [PATCH 2/2] fix typo --- src/ServiceFabric/ServiceFabric/ChangeLog.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ServiceFabric/ServiceFabric/ChangeLog.md b/src/ServiceFabric/ServiceFabric/ChangeLog.md index 5fdc779dc59b..9e9e2e483762 100644 --- a/src/ServiceFabric/ServiceFabric/ChangeLog.md +++ b/src/ServiceFabric/ServiceFabric/ChangeLog.md @@ -22,7 +22,7 @@ * Add example to Set-AzServiceFabricSetting with SettingsSectionDescription param * Update application related cmdlets to call out that support is only for ARM deployed resources * Mark for deprecation cluster cert cmdlets Add-AzureRmServiceFabricClusterCertificate and Remove-AzureRmServiceFabricClusterCertificate -* Fix add-AzServiceFabricNodeType. Add node type to service fabric cluster before creating virtual machine scale set. +* Fix Add-AzServiceFabricNodeType. Add node type to service fabric cluster before creating virtual machine scale set. ## Version 2.2.0