Remove DefaultProfile usage from constructor in ResourceManipulationCmdletBase

[huntr01]

Description

Passing in context using the AzureRmContext (DefaultProfile) optional variable does not work for Set-AzureRmResource. This works for other *-AzureRmResource commands (eg get-azurermresource).

I am calling the cmdlet via a powershell job which needs authentication/tenant details provided by the context object as described here: https://docs.microsoft.com/en-us/powershell/azure/context-persistence?view=azurermps-5.4.0

As mentioned, this works for other *-AzureRmResource commands and the documentation suggested it accepts the AzureRMContext parameter

Script/Steps for Reproduction

Create a script to run as a job called testingjobs.ps1

param($myresource, $AzureCtx)
$DebugPreference = "Continue"


#Get-AzureRmResource -ResourceId $myresource.ResourceId -AzureRmContext $AzureCtx #This works
Set-AzureRmResource -Tag $myresource.Tags -ResourceId $myresource.ResourceId -Force -AzureRmContext $AzureCtx #this does not work
Resolve-AzureRmError

Then call the script via a job, passing in the Azure Context so the cmdlets can use it to authenticate to azure. Ensure a valid ResourceID is specified in the Get-AzureRmResource

Add-AzureRmAccount
$myresource = Get-AzureRmResource -ResourceId /subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/Default-RecoveryServices-ResourceGroup-westeurope/providers/microsoft.recoveryservices/vaults/XXXresourcenameXXX
 
Start-Job -FilePath .\testingjobs.ps1 -ArgumentList ($myresource,(Get-AzureRmContext))
Get-job | Wait-Job
Get-Job | Receive-Job -Keep 

Module Version

Get-Module -Name AzureRM -ListAvailable

ModuleType Version    Name                                ExportedCommands                                                                                                                                                                                                     
---------- -------    ----                                ----------------                                                                                                                                                                                                     
Script     5.4.1      AzureRM                                                

Environment Data

$PSVersionTable
Name                           Value                                                                                                                                                                                                                                           
----                           -----                                                                                                                                                                                                                                           
PSVersion                      5.1.14393.2068                                                                                                                                                                                                                                  
PSEdition                      Desktop                                                                                                                                                                                                                                         
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}                                                                                                                                                                                                                         
BuildVersion                   10.0.14393.2068                                                                                                                                                                                                                                 
CLRVersion                     4.0.30319.42000                                                                                                                                                                                                                                 
WSManStackVersion              3.0                                                                                                                                                                                                                                             
PSRemotingProtocolVersion      2.3                                                                                                                                                                                                                                             
SerializationVersion           1.1.0.1   

Debug Output

Id     Name            PSJobTypeName   State         HasMoreData     Location             Command                  
--     ----            -------------   -----         -----------     --------             -------                  
61     Job61           BackgroundJob   Completed     True            localhost            param($myresource, $Az...
Run Connect-AzureRmAccount to login.
    + CategoryInfo          : InvalidOperation: (:) [], PSInvalidOperationException
    + FullyQualifiedErrorId : InvalidOperation
    + PSComputerName        : localhost
 
DEBUG: 14:29:45 - ResolveError begin processing with ParameterSet 'AnyErrorParameterSet'.

RunspaceId       : 5f14658c-ec3b-4f01-a272-926104c58558
InnerException   : False
Exception        : System.Management.Automation.PSInvalidOperationException: Run Connect-AzureRmAccount to login.
                      at Microsoft.Azure.Commands.ResourceManager.Common.AzureRMCmdlet.get_DefaultContext()
                      at Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.ResourceManipulationCmdletBase..ctor()
                      at lambda_method(Closure )
                      at System.Management.Automation.CommandProcessor.Init(CmdletInfo cmdletInformation)
Message          : Run Connect-AzureRmAccount to login.
StackTrace       :    at Microsoft.Azure.Commands.ResourceManager.Common.AzureRMCmdlet.get_DefaultContext()
                      at Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.ResourceManipulationCmdletBase..ctor()
                      at lambda_method(Closure )
                      at System.Management.Automation.CommandProcessor.Init(CmdletInfo cmdletInformation)
HelpLink         : 
ErrorDetails     : 
ErrorCategory    : InvalidOperation: (:) [], PSInvalidOperationException
InvocationInfo   : System.Management.Automation.InvocationInfo
ScriptStackTrace : at <ScriptBlock>, <No file>: line 6

DEBUG: AzureQoSEvent: CommandName - Resolve-AzureRmError; IsSuccess - True; Duration - 00:00:00.0590233; Exception - ;
DEBUG: Finish sending metric.
DEBUG: 14:29:46 - ResolveError end processing.
DEBUG: 14:29:46 - ResolveError end processing.

[huntr01]

Found a workaround for the moment. Add the following to the testingjobs.ps1 script causes the context to be saved for the process / session so that each command does not need to be authenticated.

Enable-AzureRmContextAutosave -Scope Process -DefaultProfile $AzureCtx

[markcowl]

@huntr01 Good catch - it looks like this particular cmdlet is trying to usethe context before the parameter is bound here: https://github.com/Azure/azure-powershell/blob/preview/src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Implementation/CmdletBase/ResourceManipulationCmdletBase.cs#L123

Need to move this code into BeginProcessing or ProcessRecord

[cormacpayne]

This has been fixed