Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Eng]: order of keys in generate-info.json is unstable #19341

Open
isra-fel opened this issue Aug 29, 2022 · 0 comments
Open

[Eng]: order of keys in generate-info.json is unstable #19341

isra-fel opened this issue Aug 29, 2022 · 0 comments
Assignees
@dolauli
Labels
Azure PS Team Engineering feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@isra-fel
Copy link
Member

Description

Order of keys in generate-info.json is unstable. This makes reviewing difficult.

Example: https://github.com/Azure/azure-powershell/pull/19337/files#diff-b660c23b3cbe88f30900b14c779d0ed626c8128ac94f066d110c5cff7d3b4f5b

image

This issue was fixed for normal autorest-based modules (Azure/autorest.powershell#938), but not for hybird modules.

Root cause: the move-generation-to-main script.
@dingmeng-xue dingmeng-xue added the feature-request This issue requires a new behavior in the product in order be resolved. label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dolauli dolauli

Labels
Azure PS Team Engineering feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@isra-fel @dolauli @dingmeng-xue