Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Wanting to use our own action group standard #472

Open
1 task done
arrerezai opened this issue Dec 20, 2024 · 1 comment
Open
1 task done

[QUESTION] Wanting to use our own action group standard #472

arrerezai opened this issue Dec 20, 2024 · 1 comment
Assignees
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern

Comments

@arrerezai
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Question

Description

Hi Gents,

I am looking to utilize the monitoring capabilities of AMBA together with the naming convention we have in place.
For that, the action group ID cannot start with "ag-amba-SH-".

Therefore, I have replaced the following:

Two occurrences in deploy_activitylog_resourcehealth_unhealthy_alert.jsonc, replaced "ag-AMBA-SH-" with our naming standard (azinf-monitoringamba-ag-) and removed the -001 in the end as I do not find it meaningful to have

Two occurrences in deploy_activitylog_servicehealth_healthadvisory.jsonc, same changes and reasoning as above

Two occurrences in deploy_activitylog_servicehealth_incident.jsonc, same changes and reasoning as above

Two occurrences in deploy_activitylog_servicehealth_maintenance.jsonc, same changes and reasoning as above

Two occurrences in deploy_activitylog_servicehealth_securityadvisory.jsonc, same changes and reasoning as above

One occurrence in deploy_servicehealth_actiongroups.jsonc, same changes and reasoning as above

Three occurrences in deploy_alertprocessing_rule.jsonc. replaced "ag-AMBA-" with our naming standard (azinf-monitoringamba-ag-) and removed the -001 in the end as I do not find it meaningful to have. Note that I didn¨t distinguish between "ag-AMBA-SH-" and "ag-AMBA-". I also did NOT do anything to "variables('varAGIds')", so this one differentiates itself from the other files

Next to that, I also replaced "apr-AMBA" like:

One occurrence in deploy_alertprocessing_rule.jsonc, replaced "apr-AMBA" with our naming standard (azinf-monitoringamba-apr-) and removed the -001 in the end as I do not find it meaningful to have

One occurrence in deploy_suppression_alertprocessing_rule.jsonc, replaced "apr-AMBA" with our naming standard (azinf-monitoringamba-apr-) and removed the -002 in the end as I do not find it meaningful to have, which means the above and this action group will become the same instead of having a suffix of -001 and -002 respectively

So far, I think I am on the right path (but please advise me if I am not).

Now, I am also trying to understand what this "SH-ActGrp" is all about in deploy_servicehealth_actiongroups.jsonc
It seems it deploys yet another action group if we haven´t inserted any value to BYOActionGroup (which we have not).
What is the purpose of this and can I define it in some other way to meet the naming convention requirement listed above?

Are there any remaining places that I¨ve missed to alter and should be configured in some way? Am I doing this all wrong or can I achieve the likes of having our own naming convention is some other/easier way?

@arrerezai arrerezai added the AMBA Core Issues / PR's related AMBA Core label Dec 20, 2024
@Brunoga-MS Brunoga-MS added Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern and removed AMBA Core Issues / PR's related AMBA Core labels Dec 20, 2024
@Brunoga-MS
Copy link
Contributor

Hello @arrerezai ,
thanks for your question. You are right. those are all the places where you need to change the values. As far as the "SH-ActGrp" goes, it is an action group used specifically by Service Health alerts. We decoupled the Service Health notification assets from the "all alerts" notification assets to add flexibility during the deployment.

Thanks,
Bruno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Development

No branches or pull requests

4 participants