From 0f6bcd26791d1dcb49714d0a41e52e83e764decb Mon Sep 17 00:00:00 2001
From: Joseph Barnes <jabarnes@me.com>
Date: Sat, 30 Sep 2023 11:43:15 -0500
Subject: [PATCH] update VMSS alert definitions

---
 docs/content/contributing/_index.md           |  4 ++
 .../Compute/virtualMachineScaleSets/_index.md |  3 +-
 .../virtualMachineScaleSets/alerts.yaml       | 41 +++++--------------
 services/Compute/virtualMachines/alerts.yaml  | 38 -----------------
 4 files changed, 16 insertions(+), 70 deletions(-)

diff --git a/docs/content/contributing/_index.md b/docs/content/contributing/_index.md
index 33092545c..8f083e0ff 100644
--- a/docs/content/contributing/_index.md
+++ b/docs/content/contributing/_index.md
@@ -74,6 +74,10 @@ Here is an example of an alert definition for an Azure Virtual Machine (Microsof
     operator: LessThan
     threshold: 1000
     criterionType: StaticThresholdCriterion
+    verified: true
+    visible: true
+    tags:
+    - alz
   references:
   - name: Supported Metrics for Microsoft.Compute/virtualMachines
     urls: https://learn.microsoft.com/azure/azure-monitor/reference/supported-metrics/microsoft-compute-virtualmachines-metrics
diff --git a/services/Compute/virtualMachineScaleSets/_index.md b/services/Compute/virtualMachineScaleSets/_index.md
index 940cc5f54..a4078f016 100644
--- a/services/Compute/virtualMachineScaleSets/_index.md
+++ b/services/Compute/virtualMachineScaleSets/_index.md
@@ -1,7 +1,6 @@
 ---
 title: virtualMachineScaleSets
 geekdocCollapseSection: true
-geekdocHidden: true
 ---
 
-{{< alertList name="alertList" >}}
\ No newline at end of file
+{{< alertList name="alertList" >}}
diff --git a/services/Compute/virtualMachineScaleSets/alerts.yaml b/services/Compute/virtualMachineScaleSets/alerts.yaml
index 6e85f5af5..34f2111bf 100644
--- a/services/Compute/virtualMachineScaleSets/alerts.yaml
+++ b/services/Compute/virtualMachineScaleSets/alerts.yaml
@@ -3,7 +3,7 @@
     by the Virtual Machine(s)
   type: Metric
   verified: false
-  visible: false
+  visible: true
   tags:
   - auto-generated
   - agc-11764
@@ -21,7 +21,7 @@
   description: Percentage of operating system disk I/Os consumed per minute
   type: Metric
   verified: false
-  visible: false
+  visible: true
   tags:
   - auto-generated
   - agc-2994
@@ -39,7 +39,7 @@
   description: Percentage of data disk I/Os consumed per minute
   type: Metric
   verified: false
-  visible: false
+  visible: true
   tags:
   - auto-generated
   - agc-2691
@@ -58,7 +58,7 @@
     (traffic going out of the VM)
   type: Metric
   verified: false
-  visible: false
+  visible: true
   tags:
   - auto-generated
   - agc-2211
@@ -77,7 +77,7 @@
     (traffic going into the VM)
   type: Metric
   verified: false
-  visible: false
+  visible: true
   tags:
   - auto-generated
   - agc-2166
@@ -96,7 +96,7 @@
     to a process or for system use in the Virtual Machine
   type: Metric
   verified: false
-  visible: false
+  visible: true
   tags:
   - auto-generated
   - agc-1543
@@ -115,7 +115,7 @@
     Machine(s) (Incoming Traffic)
   type: Metric
   verified: false
-  visible: false
+  visible: true
   tags:
   - auto-generated
   - agc-445
@@ -139,7 +139,7 @@
     (Outgoing Traffic)
   type: Metric
   verified: false
-  visible: false
+  visible: true
   tags:
   - auto-generated
   - agc-437
@@ -162,7 +162,7 @@
   description: Measure of Availability of Virtual machines over time.
   type: Metric
   verified: false
-  visible: false
+  visible: true
   tags:
   - auto-generated
   - agc-422
@@ -181,30 +181,11 @@
       values:
       - '*'
     threshold: 1.0
-- name: Network In
-  description: The number of billable bytes received on all network interfaces by
-    the Virtual Machine(s) (Incoming Traffic) (Deprecated)
-  type: Metric
-  verified: false
-  visible: false
-  tags:
-  - auto-generated
-  - agc-361
-  properties:
-    metricName: Network In
-    metricNamespace: Microsoft.Compute/virtualMachineScaleSets
-    severity: 2
-    windowSize: PT5M
-    evaluationFrequency: PT1M
-    timeAggregation: Average
-    operator: LessThan
-    criterionType: StaticThresholdCriterion
-    threshold: 1.0
 - name: Disk Read Operations/Sec
   description: Disk Read IOPS
   type: Metric
   verified: false
-  visible: false
+  visible: true
   tags:
   - auto-generated
   - agc-252
@@ -225,7 +206,7 @@
   description: Disk Write IOPS
   type: Metric
   verified: false
-  visible: false
+  visible: true
   tags:
   - auto-generated
   - agc-252
diff --git a/services/Compute/virtualMachines/alerts.yaml b/services/Compute/virtualMachines/alerts.yaml
index 6b3b951d0..0c37bf8d8 100644
--- a/services/Compute/virtualMachines/alerts.yaml
+++ b/services/Compute/virtualMachines/alerts.yaml
@@ -733,44 +733,6 @@
     operator: GreaterThan
     criterionType: StaticThresholdCriterion
     threshold: 100.0
-- name: Network In
-  description: The number of billable bytes received on all network interfaces by
-    the Virtual Machine(s) (Incoming Traffic) (Deprecated)
-  type: Metric
-  verified: false
-  visible: false
-  tags:
-  - auto-generated
-  - agc-3454
-  properties:
-    metricName: Network In
-    metricNamespace: Microsoft.Compute/virtualMachines
-    severity: 4
-    windowSize: PT5M
-    evaluationFrequency: PT5M
-    timeAggregation: Average
-    operator: LessThanOrEqual
-    criterionType: StaticThresholdCriterion
-    threshold: 1.0
-- name: Network Out
-  description: The number of billable bytes out on all network interfaces by the Virtual
-    Machine(s) (Outgoing Traffic) (Deprecated)
-  type: Metric
-  verified: false
-  visible: false
-  tags:
-  - auto-generated
-  - agc-3451
-  properties:
-    metricName: Network Out
-    metricNamespace: Microsoft.Compute/virtualMachines
-    severity: 4
-    windowSize: PT5M
-    evaluationFrequency: PT5M
-    timeAggregation: Average
-    operator: LessThanOrEqual
-    criterionType: StaticThresholdCriterion
-    threshold: 1.0
 - name: VM Cached IOPS Consumed Percentage
   description: Percentage of cached disk IOPS consumed by the VM. Only available on
     VM series that support premium storage.