Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModuleId Validate does not validate with ModuleIdProperty name but for DeviceId #2061

Closed
tjjkj opened this issue Jul 1, 2021 · 2 comments
Closed

ModuleId Validate does not validate with ModuleIdProperty name but for DeviceId #2061

tjjkj opened this issue Jul 1, 2021 · 2 comments
Assignees
@abhipsaMisra
Labels
bug Something isn't working. fix-checked-in Fix checked into main or preview, but not yet released. IoTSDK Tracks all IoT SDK issues across the board

Comments

@tjjkj
Copy link

tjjkj commented Jul 1, 2021

In the below source code, IotHubConnectionStringBuilder->Validate() validates the ModuleId using DeviceIdPropertyName instead of ModuleIdPropertyName

Code:
if (!string.IsNullOrEmpty(ModuleId))
{
ValidateFormat(ModuleId, DeviceIdPropertyName, s_idNameRegex);
}

https://github.com/Azure/azure-iot-sdk-csharp/blob/master/iothub/device/src/IotHubConnectionStringBuilder.cs
@tjjkj tjjkj added the bug Something isn't working. label Jul 1, 2021
@github-actions github-actions bot added the IoTSDK Tracks all IoT SDK issues across the board label Jul 1, 2021
@abhipsaMisra
Copy link
Member

You are correct, we will fix this right away.

@abhipsaMisra abhipsaMisra mentioned this issue Jul 2, 2021
Merged
@abhipsaMisra abhipsaMisra self-assigned this Jul 2, 2021
@abhipsaMisra abhipsaMisra added the fix-checked-in Fix checked into main or preview, but not yet released. label Jul 2, 2021
@abhipsaMisra abhipsaMisra mentioned this issue Aug 10, 2021
Merged
@abhipsaMisra
Copy link
Member

This fix has been released in our latest release: https://github.com/Azure/azure-iot-sdk-csharp/releases/tag/2021-8-11
Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhipsaMisra abhipsaMisra

Labels
bug Something isn't working. fix-checked-in Fix checked into main or preview, but not yet released. IoTSDK Tracks all IoT SDK issues across the board
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abhipsaMisra @tjjkj