[pack] moving ExtensionsMetadataGenerator to use Mono.Cecil #6052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this mostly a port of the changes applied to 2.0? |
|
These were never applied to 2.0. The PRs were out but never completed. And we don't have a v2 or v3 EMG -- this is the only one now. |
brettsam
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fabiocav
reviewed
May 19, 2020
| }; | ||
|
|
||
| extensionReferences.Add(extensionReference); | ||
| } | ||
|
|
||
| return extensionReferences; | ||
| } | ||
|
|
||
| // Copying the WebJobsStartup constructor logic from: | ||
| // https://github.com/Azure/azure-webjobs-sdk/blob/dev/src/Microsoft.Azure.WebJobs.Host/Hosting/WebJobsStartupAttribute.cs#L33-L47. |
There was a problem hiding this comment.
Can you please update the comment to use a permalink?
There was a problem hiding this comment.
Oh, to the commit rather than to the branch? Yeah, will do...
fabiocav
previously approved these changes
Jul 6, 2020
brettsam
force-pushed
the
brettsam/cecil
branch
from
1cfa91a to
e7a864a
Compare
fabiocav
previously approved these changes
Sep 28, 2020
fabiocav
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5860