-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PostgreSQL module #1355
Merged
Merged
Add PostgreSQL module #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned pamelafox
Jan 11, 2023
I ported another template today and had to make some changes to this to allow for Virtual Network support. That's going to be hairier so I don't have it ready yet. FYI in case you want to wait on review, or want that to be a follow-up PR. (It'll be an addition more than a change). |
jongio
reviewed
Jan 17, 2023
templates/common/infra/bicep/core/database/postgresql/flexibleserver.bicep
Outdated
Show resolved
Hide resolved
pamelafox
commented
Jan 19, 2023
templates/common/infra/bicep/core/database/postgresql/flexibleserver.bicep
Show resolved
Hide resolved
pamelafox
commented
Jan 19, 2023
templates/common/infra/bicep/core/database/postgresql/flexibleserver.bicep
Show resolved
Hide resolved
pamelafox
commented
Jan 19, 2023
templates/common/infra/bicep/core/database/postgresql/flexibleserver.bicep
Show resolved
Hide resolved
weikanglim
reviewed
Jan 30, 2023
templates/common/infra/bicep/core/database/postgresql/flexibleserver.bicep
Outdated
Show resolved
Hide resolved
pamelafox
commented
Jan 30, 2023
templates/common/infra/bicep/core/database/postgresql/flexibleserver.bicep
Show resolved
Hide resolved
vhvb1989
approved these changes
Jan 31, 2023
weikanglim
approved these changes
Feb 5, 2023
@weikanglim - Please merge when ready (we'll need to merge for folks that aren't in azdcore) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a module to /core for PostGreSQL flexible servers. I used sqlserver.bicep as inspiration, and ported over a simple Flask+PG app to use the module. You can see my usage here:
https://github.com/pamelafox/flask-db-quiz-example/blob/765f1a0abf4da055ac910a520ed8f26d0a076cd4/infra/main.bicep#L31
Design decisions made:
TODO: