[Profile] az account get-access-token: Return expires_on as POSIX timestamp
#27476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔄AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the October 2023 (2023-11-15)❗ Breaking change release ❗ milestone
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
zhoxing-ms and
yonzhan
|
improve expires_on |
microsoft-github-policy-service
bot
added
the
ARM
2 tasks
jiasli
added
Account
cataggar
approved these changes
Sep 27, 2023
yonzhan
previously approved these changes
Sep 27, 2023
demoray
pushed a commit
to demoray/azure-sdk-for-rust
that referenced
this pull request
Oct 3, 2023
As indicated in Azure#1371, there are numerous issues with handling the az-cli's output of an access token's expiration date when it comes to time zones. An update to the Azure CLI is in progress that will add a _new_ field that will handle the conversion, currently tracked as Azure/azure-cli#27476. We should make use of this new feature once it's available, but we should also keep this functionality as a fallback for supporting older Azure CLIs.
demoray
added a commit
to Azure/azure-sdk-for-rust
that referenced
this pull request
Oct 3, 2023
As indicated in #1371, there are numerous issues with handling the az-cli's output of an access token's expiration date when it comes to time zones. An update to the Azure CLI is in progress that will add a _new_ field that will handle the conversion, currently tracked as Azure/azure-cli#27476. We should make use of this new feature once it's available, but we should also keep this functionality as a fallback for supporting older Azure CLIs.
jiasli
commented
Oct 25, 2023
dbradish-microsoft
requested changes
Oct 25, 2023
14 tasks
evelyn-ys
previously approved these changes
Oct 31, 2023
jiasli
commented
Nov 1, 2023
dbradish-microsoft
approved these changes
Nov 2, 2023
evelyn-ys
approved these changes
Nov 2, 2023
bebound
approved these changes
Nov 3, 2023
This was referenced Nov 3, 2023
|
This PR has been released in Azure CLI 2.54.0. Whether using One thing is for sure: The access token returned by
If you want better compatibility with old versions of Azure CLI, you may allow falling back to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #19700
Related command
az account get-access-tokenDescription
Returning
expiresOnas a local datetime is a legacy from the ADAL age. It causes lots of unnecessary complexities. See #19700 for detailed explanation.This PR makes
az account get-access-tokenreturnexpires_onas POSIX timestamp which has been supported long ago by Azure CLI Core during the MSAL migration (#19853).However, as shown in #19700 (comment), downstream applications that only support 32-bit integer precision timestamp will encounter error in year 2038, but that's not something we can control.
Testing Guide
Before:
After: