{AKS} update logs DCR to cluster resource group instead of workspace resource group for consistency with Prometheus Addon #23630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bragi92
changed the title
|
AKS |
bragi92
requested review from
zhoxing-ms,
andyliuliming and
jsntcy
as code owners
zhoxing-ms
approved these changes
Aug 24, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
This PR is updating the creation of the DCR to the clusters resource group instead of the workspaces resource group to make it consistent with our new addon experience (managed prometheus azure monitor metrics addon)
Testing Guide
az aks enable-addons -a monitoring --enable-msi-auth-for-monitoring -g kaveeshclitest -n kaveesh11
Use the flag '--enable-msi-auth-for-monitoring' to be able to test that the new MSI is being created in the clusters resource group.
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.