[Interactive] Fix #16931: Fix KeyError in az interactive --update
#17389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
reviewed
Mar 22, 2021
Comment on lines
488
to
491
| try: | ||
| return reload_module(extension_module if extension_module else get_extension_modname(ext_name=extension_name)) | ||
| except KeyError: | ||
| pass |
There was a problem hiding this comment.
How about we put the try except clause in
az interactive should be responsible for non-existing extension, such as ExtensionNotInstalledException.
fengzhou-msft
force-pushed
the
fix_reload_extension
branch
from
6a8e36d to
b732f72
Compare
fengzhou-msft
requested review from
evelyn-ys,
houk-ms,
jsntcy and
Juliehzl
as code owners
fengzhou-msft
changed the title
KeyError for reload_extensionKeyError in az interactive --update
jiasli
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #16931
interactiveis written in a special way that it is anazure-climodule, but it will install theinterativeextension for starting an interactive shell. With the use of command index,interactivecommand group only loads theinteractivemodule and notazext_interactivemodule as the extension has 0 command. That's whyreload_modulewill throwKeyErrorwhen trying to reloadazext_interactiveafter updated.This PR adds check whether the module is already imported before reloading it.
Testing Guide
interactiveaz extension add --upgrade -n interactive --version 0.4.3interactiveaz interactive --updateHistory Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.