Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig image-version create managed-image parameter should map to new VM backend field #28488

Closed
1 task done
tiregan opened this issue Feb 29, 2024 · 1 comment · Fixed by #28627
Closed
1 task done
Assignees
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team Compute az vm/vmss/image/disk/snapshot feature-request
Milestone

Comments

@tiregan
Copy link

tiregan commented Feb 29, 2024

Preconditions

  • No need to upgrade Python SDK or the Python SDK is ready.

Related command

az sig image-version create

Resource Provider

Microsoft.Compute

Description of Feature or Work Requested

Currently, the --managed-image parameter of the az sig image-version create command maps to the properties.storageprofile.source.id field. We need it to map to the properties.storageprofile.source.virtualMachineId field ONLY when the source provided is a VM id.

Minimum API Version Required

2023_07_03

Swagger PR link / SDK link

Azure/azure-rest-api-specs#27518

Request Example

Example of how it would be mapped today:
{
"name": "1.0.0",
"location": "South Central US STG",
"properties": {
"storageProfile": {
"source": {
"id": "{virtual machine id}"
}
}
}
}

The new mapping:
{
"name": "1.0.0",
"location": "South Central US STG",
"properties": {
"storageProfile": {
"source": {
"virtualMachineId": "{virtual machine id}"
}
}
}
}

Not we should only use the virtualMachineId if the id is a virtual machine. If the id is a managed image then we should continue to use the old field.

Target Date

As soon as possible

PM Contact

[email protected]

Engineer Contact

tiregan, jerch, kagarwal

Additional context

No response

@microsoft-github-policy-service microsoft-github-policy-service bot added the Compute az vm/vmss/image/disk/snapshot label Feb 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 29, 2024
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 29, 2024

Thank you for opening this issue, we will look into it.

@yonzhan yonzhan added this to the Backlog milestone Mar 1, 2024
@yonzhan yonzhan removed the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Mar 1, 2024
@zhoxing-ms zhoxing-ms assigned Jing-song and unassigned yanzhudd Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team Compute az vm/vmss/image/disk/snapshot feature-request
Projects
None yet
6 participants