Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogAnalytics: support new resources of QueryPacks #22310

Closed
dabenhamMic opened this issue May 9, 2022 · 6 comments · Fixed by #22986
Closed

LogAnalytics: support new resources of QueryPacks #22310

dabenhamMic opened this issue May 9, 2022 · 6 comments · Fixed by #22986

Comments

@dabenhamMic
Copy link

dabenhamMic commented May 9, 2022

Related command

our latest swagger change included an update to QueryPacks module: Azure/azure-rest-api-specs#17923
Python SDK: https://pypi.org/project/azure-mgmt-loganalytics/13.0.0b4/

Resource Provider

OperationalInsights (LogAnalytics)

Description of Feature or Work Requested

A request to bump up CLI cersion to latest Python SDK was already creatted after Python SDK was released: #22013

this did not include any changes to 2 modules:

  1. QueryPAcks
  2. QueryPackQueries

Minimum API Version Required

Python SDK ver 13.0.0b4

Swagger Link

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/operationalinsights/resource-manager/readme.md#tag-package-2022-02

Target Date

@yonzhan
Copy link
Collaborator

yonzhan commented May 9, 2022

monitor

@kairu-ms
Copy link
Contributor

@dabenhamMic I'm confuse about this swagger property. What's it used for and why it does have any detailed schema definition? Is this property read-only?

@dabenhamMic
Copy link
Author

@dabenhamMic I'm confuse about this swagger property. What's it used for and why it does have any detailed schema definition? Is this property read-only?

you can leave this property out of CLI experience

@kairu-ms kairu-ms changed the title OperationalInsights: add support for latest swagger update LogAnalytics: support new resources of QueryPacks May 20, 2022
@dabenhamMic
Copy link
Author

dabenhamMic commented Jun 1, 2022

Hi @kairu-ms @jsntcy

We have a couple of open tickets on the CLI module:
https://msazure.visualstudio.com/One/_workitems/edit/14318495
https://msazure.visualstudio.com/One/_workitems/edit/14318510

Bugs description:

  1. Updating CMK key with empty version “” fails. I verified and it works fine in REST
    PS C:\Users\yossiy> $kUri = 'https://yossiy-eus.vault.azure.net'
    PS C:\Users\yossiy> $kName = 'yossiy-test1'
    PS C:\Users\yossiy> $kVersion = ''
    PS C:\Users\yossiy> az monitor log-analytics cluster update --name $clusterName --resource-group $rg --key-name $kName --key-vault-uri $kUri --key-version $kVersion
    argument --key-version: expected one argument

  2. Updating BillingType not supported. I verified and it works fine in REST
    PS C:\Users\yossiy> az monitor log-analytics cluster update --name $clusterName --resource-group $rg 'Workspaces'
    unrecognized arguments: Workspaces

can you please add these changes to the upcoming update as well?

6.12.2022 update:
removed the bugs ask from this issue and created a new separate one: #22842

@kairu-ms
Copy link
Contributor

kairu-ms commented Jun 6, 2022

Hi @kairu-ms @jsntcy

We have a couple of open tickets on the CLI module: https://msazure.visualstudio.com/One/_workitems/edit/14318495 https://msazure.visualstudio.com/One/_workitems/edit/14318510

Bugs description:

  1. Updating CMK key with empty version “” fails. I verified and it works fine in REST
    PS C:\Users\yossiy> $kUri = 'https://yossiy-eus.vault.azure.net'
    PS C:\Users\yossiy> $kName = 'yossiy-test1'
    PS C:\Users\yossiy> $kVersion = ''
    PS C:\Users\yossiy> az monitor log-analytics cluster update --name $clusterName --resource-group $rg --key-name $kName --key-vault-uri $kUri --key-version $kVersion
    argument --key-version: expected one argument
  2. Updating BillingType not supported. I verified and it works fine in REST
    PS C:\Users\yossiy> az monitor log-analytics cluster update --name $clusterName --resource-group $rg 'Workspaces'
    unrecognized arguments: Workspaces

can you please add these changes to the upcoming update as well?

Hi @dabenhamMic, could you create another feature request issue for this? Thanks.

@dabenhamMic
Copy link
Author

dabenhamMic commented Jun 12, 2022

@kairu-ms thanks for your response.
opened a new issue: #22842
removing the bugs ask from this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment