Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] support download managed disk from SASUri + bearer token #20969

Closed
blueww opened this issue Jan 13, 2022 · 5 comments
Closed

[Storage] support download managed disk from SASUri + bearer token #20969

blueww opened this issue Jan 13, 2022 · 5 comments
Assignees
Labels
feature-request Service Attention This issue is responsible by Azure service team. Storage az storage

Comments

@blueww
Copy link
Member

blueww commented Jan 13, 2022

Resource Provider

Storage Dataplane

Description of Feature or Work Requested

Download blob from a SASUri of management disk, with a bearer token

Like following is a sample request from .net SDK.
Note it has both SAS in Uri, and Authorization: Bearer

HEAD https://md-hdd-zhkcjtvz5j3s.z5.blob.storage.azure.net/q1vl4npgqcpb/abcd?sv=2018-03-28&sr=b&si=fd9b7490-bd27-4ebd-9f49-8e7f40f2c860&sig=[hidden] HTTP/1.1
x-ms-version: 2020-10-02
Accept: application/xml
User-Agent: AzurePowershell/v1.0.0,azsdk-net-Storage.Blobs/12.10.0 (.NET Framework 4.8.4300.0; Microsoft Windows 10.0.19044 )
x-ms-client-request-id: c276f6ac-158e-4a93-b448-9aee351b7a2f
x-ms-return-client-request-id: true
Authorization: Bearer [token hidden]
Host: weirp1.blob.core.windows.net
Connection: Keep-Alive

Minimum API Version Required

TBD
(per my test, it works on 2020-10-02 API version.)

Swagger Link

No Swagger change

Target Date

TBD, firstly it's better we can provide private package for CLI for internal test.

@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jan 13, 2022
@yonzhan yonzhan added the Storage az storage label Jan 13, 2022
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jan 13, 2022
@yonzhan yonzhan added feature-request needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Jan 13, 2022
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jan 13, 2022
@yonzhan yonzhan added this to the Feb 2022 (2022-03-01) milestone Jan 13, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Jan 13, 2022

Storage

@evelyn-ys evelyn-ys added the Service Attention This issue is responsible by Azure service team. label Jan 25, 2022
@ghost
Copy link

ghost commented Jan 25, 2022

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

Issue Details

Resource Provider

Storage Dataplane

Description of Feature or Work Requested

Download blob from a SASUri of management disk, with a bearer token

Like following is a sample request from .net SDK.
Note it has both SAS in Uri, and Authorization: Bearer

HEAD https://md-hdd-zhkcjtvz5j3s.z5.blob.storage.azure.net/q1vl4npgqcpb/abcd?sv=2018-03-28&sr=b&si=fd9b7490-bd27-4ebd-9f49-8e7f40f2c860&sig=[hidden] HTTP/1.1
x-ms-version: 2020-10-02
Accept: application/xml
User-Agent: AzurePowershell/v1.0.0,azsdk-net-Storage.Blobs/12.10.0 (.NET Framework 4.8.4300.0; Microsoft Windows 10.0.19044 )
x-ms-client-request-id: c276f6ac-158e-4a93-b448-9aee351b7a2f
x-ms-return-client-request-id: true
Authorization: Bearer [token hidden]
Host: weirp1.blob.core.windows.net
Connection: Keep-Alive

Minimum API Version Required

TBD
(per my test, it works on 2020-10-02 API version.)

Swagger Link

No Swagger change

Target Date

TBD, firstly it's better we can provide private package for CLI for internal test.

Author: blueww
Assignees: evelyn-ys
Labels:

Storage, Service Attention, feature-request

Milestone: Jan 2022 (2022-02-08)

@evelyn-ys
Copy link
Member

evelyn-ys commented Jan 25, 2022

Need Storage data plane Python SDK team to confirm if it's supported or not. @tasherif-msft

@jiasli
Copy link
Member

jiasli commented Feb 14, 2022

Is there any document describing why and how SAS and Bearer token should be used at the same time? Is this similar to https://docs.microsoft.com/en-us/rest/api/storageservices/create-user-delegation-sas ?

@blueww
Copy link
Member Author

blueww commented Feb 14, 2022

@jiasli
Doc has shared in teams.
The usage is not user delegation SAS. It need both SAS and bearer token request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Service Attention This issue is responsible by Azure service team. Storage az storage
Projects
None yet
Development

No branches or pull requests

4 participants