Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure-ci-core has a strict dependency on an very old PyJWT #17939

Closed
sodul opened this issue May 1, 2021 · 2 comments · Fixed by #18506
Closed

Azure-ci-core has a strict dependency on an very old PyJWT #17939

sodul opened this issue May 1, 2021 · 2 comments · Fixed by #18506
Assignees
Labels
Milestone

Comments

@sodul
Copy link

sodul commented May 1, 2021

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
The setup.py for azure-cli-core explicitly requires PyJWT==1.7.1 while all the other azure packages are more relaxed with >=1.0.0,<3.

https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/setup.py#L61

To Reproduce
pip install azure-cli alongside more recent packages that need PyJWT>= 2.0.

pip install azure-cli==2.22.1 PyJWT==2.1.0
... 
ERROR: Cannot install PyJWT==2.1.0 and azure-cli-core==2.22.1 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested PyJWT==2.1.0
    azure-cli-core 2.22.1 depends on PyJWT==1.7.1

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies
WARNING: You are using pip version 21.0.1; however, version 21.1.1 is available.

Expected behavior
We should not have a version conflict with newer versions of PyJWT when installing the latest azure cli.

Environment summary
Installed with python 3.9.4 on linux and macOS. Pip 21.0.1.

Additional context
PyJWT 1.7.1 was released on 2018. This bug relates to #17598.

@ghost ghost added needs-triage This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 1, 2021
@yonzhan yonzhan added the Core CLI core infrastructure label May 1, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label May 1, 2021
@yonzhan yonzhan removed the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label May 1, 2021
@yonzhan yonzhan added this to the S187 milestone May 1, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented May 1, 2021

@jiasli for awareness

@sodul sodul changed the title Azure-ci-core has a strict dependency on an very old PyJWT depends on ol Azure-ci-core has a strict dependency on an very old PyJWT May 5, 2021
@yonzhan yonzhan modified the milestones: S187, S188 May 9, 2021
@yonzhan yonzhan modified the milestones: S188, S189 Jun 12, 2021
@fshabashev
Copy link

affects me as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants