Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageBuilder commands improve and new features #12184

Closed
qwordy opened this issue Feb 13, 2020 · 4 comments
Closed

ImageBuilder commands improve and new features #12184

qwordy opened this issue Feb 13, 2020 · 4 comments
Assignees
Labels
Compute - Images az image Compute az vm/vmss/image/disk/snapshot Service Team Support Request
Milestone

Comments

@qwordy
Copy link
Member

qwordy commented Feb 13, 2020

Resource Provider
What is the Azure resource provider your feature is part of?
Microsoft.VirtualMachineImages

Description of Feature or Work Requested
Provide a brief description of the feature or work requested. A link to conceptual documentation may be helpful too.

  1. Rename image template to image builder.
  2. Support specifying image template in image builder create , e.g. --image-template-path.

Minimum API Version Required
What is the minimum API version of your service required to implement your feature?
2019-05-01-preview

Swagger Link
Provide a link to the location of your feature(s) in the REST API specs repo. If your feature(s) has corresponding commit or pull request in the REST API specs repo, provide them. This should be on the master branch of the REST API specs repo.

Target Date
If you have a target date for release of this feature/work, please provide it. While we can't guarantee these dates,
it will help us prioritize your request against other requests.
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/preview

@qwordy qwordy added this to the S167 milestone Feb 13, 2020
@qwordy qwordy self-assigned this Feb 13, 2020
@arrownj arrownj added Compute az vm/vmss/image/disk/snapshot Compute - Images az image and removed triage labels Feb 14, 2020
@arrownj
Copy link
Contributor

arrownj commented Feb 14, 2020

Hi @qwordy , please help take this issue.

@qwordy
Copy link
Member Author

qwordy commented Feb 14, 2020

Usage of image template:
"NumInvocations": 46,
"UniqueSubscriptions": 17,

Query:
HttpIncomingRequests
| where TIMESTAMP > ago(30d)
| where userAgent contains 'AzureCLI/2.'
| where commandName startswith 'image template'
| summarize NumInvocations=dcount(clientRequestId), UniqueSubscriptions=dcount(subscriptionId)

No risk to rename "template" to "builder"

@yungezz yungezz changed the title ImageBuilder ImageBuilder commands improve and new features Feb 14, 2020
@yungezz
Copy link
Member

yungezz commented Feb 14, 2020

thanks @qwordy , it's great no user impact of renaming template to builder. Let's use this issue for item 1 and 2. for further asks, let's use new issue.

@yungezz
Copy link
Member

yungezz commented Mar 12, 2020

Fixed by PR #11865, released at 2.2.0 already, close this one

@yungezz yungezz closed this as completed Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compute - Images az image Compute az vm/vmss/image/disk/snapshot Service Team Support Request
Projects
None yet
Development

No branches or pull requests

3 participants