-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
containerapp add three type for enable workload profiles #6647
Merged
zhoxing-ms
merged 3 commits into
Azure:main
from
Greedygre:xinyu/set_3_type_enable_workload_profiles
Aug 16, 2023
Merged
containerapp add three type for enable workload profiles #6647
zhoxing-ms
merged 3 commits into
Azure:main
from
Greedygre:xinyu/set_3_type_enable_workload_profiles
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌Azure CLI Extensions Breaking Change Test
|
Hi @Greedygre, |
microsoft-github-policy-service
bot
requested review from
yonzhan,
wangzelin007,
yanzhudd and
zhoxing-ms
August 15, 2023 07:46
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
jsntcy,
ruslany,
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek,
torosent,
pagariyaalok,
Juliehzl and
jijohn14
August 15, 2023 07:46
Juliehzl
reviewed
Aug 15, 2023
Juliehzl
reviewed
Aug 15, 2023
src/containerapp/azext_containerapp/tests/latest/test_containerapp_workload_profile_commands.py
Outdated
Show resolved
Hide resolved
Juliehzl
approved these changes
Aug 15, 2023
zhoxing-ms
approved these changes
Aug 15, 2023
Hi, @zhoxing-ms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp env create
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.