-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update remote connection #659
Conversation
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
|
2e32e1a
to
64922fe
Compare
this is ready for review |
Didn't you move this to core already any reason you want the changes here in the extension as well? |
Also been a while since I worked on extensions - do you not need to update the version # anymore for this to take effect? |
65fe4a1
to
1fa7c5b
Compare
I only really need the warning message, I fixed some bugs while I was here. |
110eb75
to
a62b3a3
Compare
@patricklee2 can you merge your branch to the latest & i can merge. Looks like the changes to cli-core are now live. |
@patrick the new changes are missing the the version updates & the whl file updates? Di we not need that anymore? |
oops removed them by accident, let me fix that |
merge after 5/6
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions: