Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update remote connection #659

Merged
merged 6 commits into from
May 6, 2019
Merged

update remote connection #659

merged 6 commits into from
May 6, 2019

Conversation

patricklee2
Copy link
Contributor

@patricklee2 patricklee2 commented Apr 29, 2019

merge after 5/6


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/patricklee2/azure-cli-extensions.git@remote#subdirectory=src/$EXT&egg=$EXT"

@patricklee2 patricklee2 force-pushed the remote branch 8 times, most recently from 2e32e1a to 64922fe Compare April 30, 2019 00:32
@patricklee2
Copy link
Contributor Author

this is ready for review

@panchagnula
Copy link
Contributor

Didn't you move this to core already any reason you want the changes here in the extension as well?

@panchagnula
Copy link
Contributor

Also been a while since I worked on extensions - do you not need to update the version # anymore for this to take effect?

@patricklee2 patricklee2 force-pushed the remote branch 2 times, most recently from 65fe4a1 to 1fa7c5b Compare May 1, 2019 19:24
@patricklee2 patricklee2 requested a review from tjprescott as a code owner May 1, 2019 19:24
@patricklee2
Copy link
Contributor Author

I only really need the warning message, I fixed some bugs while I was here.
I added the versions update

@patricklee2 patricklee2 force-pushed the remote branch 5 times, most recently from 110eb75 to a62b3a3 Compare May 1, 2019 21:01
@panchagnula
Copy link
Contributor

@patricklee2 can you merge your branch to the latest & i can merge. Looks like the changes to cli-core are now live.

@panchagnula
Copy link
Contributor

@patrick the new changes are missing the the version updates & the whl file updates? Di we not need that anymore?

@patricklee2
Copy link
Contributor Author

oops removed them by accident, let me fix that

@panchagnula panchagnula merged commit 267d086 into Azure:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants