{AKS} Remove the error prompt about "no argument specified" when --enable-workload-identity=False is specified
#5723
Conversation
ghost
requested review from
ghost
assigned 
src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
| @@ -312,7 +312,7 @@ def load_arguments(self, _): | |||
| c.argument('enable_vmss', action='store_true', help='To be deprecated. Use vm_set_type instead.', deprecate_info=c.deprecate(redirect='--vm-set-type', hide=True)) | |||
| c.argument('zones', zones_type, options_list=['--zones', '-z'], help='Space-separated list of availability zones where agent nodes will be placed.') | |||
| c.argument('ppg') | |||
| c.argument('enable_encryption_at_host', arg_type=get_three_state_flag(), help='Enable EncryptionAtHost.') | |||
| c.argument('enable_encryption_at_host', action='store_true') | |||
There was a problem hiding this comment.
The help information corresponding to this option has been written in a separate _help.py file, so remove duplicates here.
There was a problem hiding this comment.
The declaration of this option in azure-cli/acs is an ordinary bool flag, and this option does not support update. So remove the confusing three state flag.
There was a problem hiding this comment.
@FumingZhang I'd like to confirm whether changing get_three_state_flag() to action='store_true' will cause a breaking change to users? Did any users use --enable-encryption-at-host False before?
There was a problem hiding this comment.
Hi @zhoxing-ms, I think this wouldn't be a breaking change to users.
This property does not support being updated, it is only allowed to be used when creating an aks cluster, and the default value is false, only need to be specified when this feature needs to be enabled.
In the official doc, the example given in the guide is in the form of az aks create xxx --enable-encryption-at-host.
Besides the option is also supported in azure-cli/acs, and the same parameter declared there is a normal bool flag.
|
AKS |
FumingZhang
force-pushed
the
fuming/fix-aks-update-prompt-0104
branch
from
85af860 to
ef8555c
Compare
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=24774&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Remove the error prompt about "no argument specified" when
--enable-workload-identity=Falseis specified.Related command
az aks update --enable-workload-identity=FalseGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.