Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Vendor new SDK and bump API version to 2022-11-02-preview #5666

Merged
merged 4 commits into from
Dec 29, 2022

Conversation

FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Dec 27, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

  • {AKS} Vendor new SDK and bump API version to 2022-11-02-preview.
  • Fix test case test_aks_nodepool_add_with_disable_windows_outbound_nat. Set the ossku of the new nodepool to Windows2019, since Windows2022 does not support this feature at present.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and yanzhudd December 27, 2022 02:15
@ghost ghost assigned zhoxing-ms Dec 27, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Dec 27, 2022
@ghost ghost requested a review from yonzhan December 27, 2022 02:15
@ghost ghost added the AKS label Dec 27, 2022
@yonzhan yonzhan added this to the Dec 2022 (2023-01-10) milestone Dec 27, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 27, 2022

AKS

@FumingZhang FumingZhang marked this pull request as ready for review December 28, 2022 06:17
@zhoxing-ms
Copy link
Contributor

@FumingZhang Do you need to upgrade a new version to release this PR?

@FumingZhang
Copy link
Member Author

Hey @zhoxing-ms, I think it's not necessary to release a new version. It would be fine to release a new version after some new features are included.

@zhoxing-ms zhoxing-ms merged commit 2708617 into Azure:main Dec 29, 2022
@FumingZhang FumingZhang deleted the fuming/aks-vendor-skd-1227 branch December 30, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants