Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Wait for LRO before enabling GuestManagement #5631

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

nascarsayan
Copy link
Contributor

@nascarsayan nascarsayan commented Dec 12, 2022

Wait for SystemAssigned Identity PATCH to complete before enabling Guest management on VM


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from yonzhan and zhoxing-ms December 12, 2022 12:25
@ghost ghost added the Auto-Assign Auto assign by bot label Dec 12, 2022
@ghost ghost requested a review from wangzelin007 December 12, 2022 12:26
@ghost ghost assigned zhoxing-ms Dec 12, 2022
@ghost ghost added the Compute label Dec 12, 2022
@nascarsayan nascarsayan changed the title Wait for SystemAssigned Identity PATCH to complete before enabling Gu… Bug Fix: Wait for LRO before enabling GuestManagement Dec 12, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 12, 2022

connectedvmware

@yonzhan yonzhan requested a review from yanzhudd December 12, 2022 12:31
@yonzhan yonzhan added this to the Dec 2022 (2023-01-10) milestone Dec 12, 2022
@nascarsayan
Copy link
Contributor Author

@zhoxing-ms , can you review the PR once? I've fixed the lint issue.

@yanzhudd yanzhudd merged commit 5353b54 into Azure:main Dec 23, 2022
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ connectedvmware ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=21974&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Compute
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants