Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI} Check cli core min version both remote and local #5604

Merged
merged 7 commits into from
Dec 6, 2022

Conversation

wangzelin007
Copy link
Member

@wangzelin007 wangzelin007 commented Dec 6, 2022

Now we download the wheel package from downloadUrl provided by index.json, then check whether the cli core min version is included in the azext_metadata.json file.
But the index.json is not automatically updated until we merge the PR, so this test is always delayed.
This PR will first search for the latest azext_metadata.json file in remote wheel package, and if it can't be found in remote wheel package, then search from the local git azext_metadata.json file.

Test screenshot:
image

@ghost ghost added Auto-Assign Auto assign by bot CI labels Dec 6, 2022
@ghost ghost requested review from yonzhan, jiasli, kairu-ms and jsntcy December 6, 2022 02:59
@ghost ghost assigned wangzelin007 Dec 6, 2022
@ghost ghost added this to the Dec 2022 (2023-01-03) milestone Dec 6, 2022
@wangzelin007 wangzelin007 marked this pull request as ready for review December 6, 2022 04:17
@wangzelin007 wangzelin007 changed the title {CI} Check cli core min version both local and remote {CI} Check cli core min version both remote and local Dec 6, 2022
@wangzelin007 wangzelin007 merged commit cfd1e19 into Azure:main Dec 6, 2022
wangzelin007 added a commit to wangzelin007/azure-cli-extensions that referenced this pull request Dec 6, 2022
commit cfd1e19
Author: ZelinWang <[email protected]>
Date:   Tue Dec 6 12:21:45 2022 +0800

    {CI} Check cli core min version both remote and local (Azure#5604)

    * update

    * Update test_index.py

    * Update test_index.py

    * Update test_index.py

    * Update test_index.py

    * Update azext_metadata.json

    * Update test_index.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants