-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Container App]: Remove quota check for 'az containerapps env create' #5548
[Container App]: Remove quota check for 'az containerapps env create' #5548
Conversation
Container App |
This will break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave validate_environment_location
as-is and simply remove the call of validate_managed_environment
from create_managed_environment
. containerapp up
auto creates environments and therefore needs to ensure the environment is created so it must be sure there is available quota on region using validate_environment_logic
. Removing this would result in a worse customer experience.
|
@Zijian-Ju Do you want to release a new extension version for this PR change? If so, please write the description of PR change into the |
Currently we do allow our customers to create more than 5 managed environments in a region after they submitted a quota request. Otherwise we restrict some of the customers to create less than 5 environments according to their subscription offer type. In this case, will it still block customers to create environment using 'az container up' when they are allowed to create more? |
92645c2
to
a52bb50
Compare
else: | ||
raise ValidationError("You cannot create any more environments. Environments are limited to {} per location in a subscription. Please specify an existing environment using --environment.".format(MAX_ENV_PER_LOCATION)) | ||
return res_locations[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add null check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
res_location will not be empty after the change as we don't filter by remaining quota anymore
Hi @zhoxing-ms, could you please help merge this PR and make a new release? The customer is urgently waiting the fix. Thank you |
[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=16319&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json
.