Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS][TA] remove source_resource_id of rolebinding update command #5202

Merged
merged 4 commits into from
Aug 12, 2022

Conversation

YitongFeng-git
Copy link
Contributor

@YitongFeng-git YitongFeng-git commented Aug 4, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 August 4, 2022 10:57
@ghost ghost assigned zhoxing-ms Aug 4, 2022
@ghost ghost added this to the Aug 2022 (2022-09-06) milestone Aug 4, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Aug 4, 2022
@ghost ghost requested a review from yonzhan August 4, 2022 10:58
@ghost ghost added the AKS label Aug 4, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 4, 2022

AKS

Yitong Feng added 2 commits August 5, 2022 16:27
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karataliu
Copy link
Contributor

@zhoxing-ms Thanks for the comment.

Regarding removal of source_resource_id parameter:
This feature is still in private preview so only internal team has access to the API. I can confirm there is no external impact.
Do you think it's ok to proceed? Thank you.

@zhoxing-ms zhoxing-ms merged commit c48595e into Azure:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants