Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Fix several tests #4919

Merged
merged 12 commits into from
Jun 2, 2022
Merged

Conversation

FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Jun 1, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Fix test cases

  • test_aks_create_and_update_with_csi_drivers_extensibility
  • test_aks_create_with_standard_csi_drivers
  • test_aks_create_with_csi_driver_v2
  • test_aks_create_and_update_csi_driver_to_v2

Temporally disable test cases

  • test_aks_create_with_azurekeyvaultkms
  • test_aks_update_with_azurekeyvaultkms

Related command

  • az aks addon list-available
  • az aks addon list
  • az aks addon show

Some of the addon commands are broken by the newly added addon web application routing by PR #4872. cc @yizhang4321

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 June 1, 2022 06:08
@ghost ghost assigned zhoxing-ms Jun 1, 2022
@ghost ghost added this to the Jun 2022 (2022-07-05) milestone Jun 1, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Jun 1, 2022
@ghost ghost requested a review from yonzhan June 1, 2022 06:09
@ghost ghost added the AKS label Jun 1, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 1, 2022

AKS

@FumingZhang FumingZhang marked this pull request as ready for review June 2, 2022 01:58
@FumingZhang FumingZhang force-pushed the fuming/fix-test-0531 branch from 740f678 to 9dbc295 Compare June 2, 2022 06:06
@zhoxing-ms zhoxing-ms merged commit d9ab65a into Azure:main Jun 2, 2022
@FumingZhang FumingZhang deleted the fuming/fix-test-0531 branch June 13, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants