Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{aks-preview} | Fixes typo Github to GitHub #4913

Merged
merged 1 commit into from
May 31, 2022

Conversation

RakeshMohanMSFT
Copy link
Contributor

Fixes Azure/azure-cli#22673


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 May 31, 2022 04:09
@ghost ghost assigned zhoxing-ms May 31, 2022
@ghost ghost added this to the Jun 2022 (2022-07-05) milestone May 31, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label May 31, 2022
@ghost ghost requested a review from yonzhan May 31, 2022 04:09
@ghost ghost added the AKS label May 31, 2022
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonzhan
Copy link
Collaborator

yonzhan commented May 31, 2022

aks-preview

@zhoxing-ms zhoxing-ms merged commit c62273e into Azure:main May 31, 2022
@RakeshMohanMSFT RakeshMohanMSFT deleted the patch-1 branch May 31, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo "Github"→"GitHub"
4 participants