Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove preview tags for enterprise tier GA #4886

Merged
merged 4 commits into from
May 24, 2022
Merged

remove preview tags for enterprise tier GA #4886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e06b93
remove preview tags for enterprise tier GA
smile37773 May 24, 2022
85f17eb
remove preview tags
smile37773 May 24, 2022
562551d
remove preview tags
smile37773 May 24, 2022
ecc8956
remove preview tags
smile37773 May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/spring/azext_spring/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,16 +117,13 @@ def load_arguments(self, _):
c.argument('build_pool_size',
arg_type=get_enum_type(['S1', 'S2', 'S3', 'S4', 'S5']),
validator=validate_build_pool_size,
is_preview=True,
help='(Enterprise Tier Only) Size of build agent pool. See https://aka.ms/azure-spring-cloud-build-service-docs for size info.')
c.argument('enable_application_configuration_service',
action='store_true',
is_preview=True,
options_list=['--enable-application-configuration-service', '--enable-acs'],
help='(Enterprise Tier Only) Enable Application Configuration Service.')
c.argument('enable_service_registry',
action='store_true',
is_preview=True,
options_list=['--enable-service-registry', '--enable-sr'],
help='(Enterprise Tier Only) Enable Service Registry.')
c.argument('enable_gateway',
Expand Down Expand Up @@ -184,7 +181,6 @@ def load_arguments(self, _):
hide=True))
c.argument('build_pool_size',
arg_type=get_enum_type(['S1', 'S2', 'S3', 'S4', 'S5']),
is_preview=True,
help='(Enterprise Tier Only) Size of build agent pool. See https://aka.ms/azure-spring-cloud-build-service-docs for size info.')

for scope in ['spring create', 'spring update']:
Expand Down Expand Up @@ -340,7 +336,7 @@ def prepare_logs_argument(c):
c.argument('config_file_patterns',
help="(Enterprise Tier Only) Config file patterns separated with \',\' to decide which patterns "
"of Application Configuration Service will be used. Use '\"\"' to clear existing configurations.",
validator=validate_config_file_patterns, is_preview=True)
validator=validate_config_file_patterns)

with self.argument_context('spring app scale') as c:
c.argument('cpu', arg_type=cpu_type)
Expand All @@ -357,7 +353,7 @@ def prepare_logs_argument(c):
c.argument(
'disable_validation', arg_type=get_three_state_flag(),
help='If true, disable jar validation.')
c.argument('builder', help='(Enterprise Tier Only) Build service builder used to build the executable.', default='default', is_preview=True)
c.argument('builder', help='(Enterprise Tier Only) Build service builder used to build the executable.', default='default')
c.argument(
'main_entry', options_list=[
'--main-entry', '-m'], help="A string containing the path to the .NET executable relative to zip root.")
Expand Down
12 changes: 5 additions & 7 deletions src/spring/azext_spring/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,17 +224,15 @@ def load_command_table(self, _):

with self.command_group('spring service-registry',
custom_command_type=service_registry_cmd_group,
exception_handler=handle_asc_exception,
is_preview=True) as g:
exception_handler=handle_asc_exception) as g:
g.custom_show_command('show', 'service_registry_show',
table_transformer=transform_service_registry_output)
g.custom_command('bind', 'service_registry_bind')
g.custom_command('unbind', 'service_registry_unbind')

with self.command_group('spring application-configuration-service',
custom_command_type=application_configuration_service_cmd_group,
exception_handler=handle_asc_exception,
is_preview=True) as g:
exception_handler=handle_asc_exception) as g:
g.custom_command('clear', 'application_configuration_service_clear')
g.custom_show_command('show', 'application_configuration_service_show',
table_transformer=transform_application_configuration_service_output)
Expand Down Expand Up @@ -298,22 +296,22 @@ def load_command_table(self, _):

with self.command_group('spring build-service builder',
custom_command_type=builder_cmd_group,
exception_handler=handle_asc_exception, is_preview=True) as g:
exception_handler=handle_asc_exception) as g:
g.custom_command('create', 'create_or_update_builder', supports_no_wait=True)
g.custom_command('update', 'create_or_update_builder', supports_no_wait=True)
g.custom_show_command('show', 'builder_show')
g.custom_command('delete', 'builder_delete', supports_no_wait=True, confirmation=True)

with self.command_group('spring build-service builder buildpack-binding',
custom_command_type=buildpack_binding_cmd_group,
exception_handler=handle_asc_exception, is_preview=True) as g:
exception_handler=handle_asc_exception) as g:
g.custom_command('create', 'create_or_update_buildpack_binding')
g.custom_command('set', 'create_or_update_buildpack_binding')
g.custom_show_command('show', 'buildpack_binding_show')
g.custom_command('list', 'buildpack_binding_list')
g.custom_command('delete', 'buildpack_binding_delete', confirmation=True)

with self.command_group('spring build-service', exception_handler=handle_asc_exception, is_preview=True):
with self.command_group('spring build-service', exception_handler=handle_asc_exception):
pass

with self.command_group('spring', exception_handler=handle_asc_exception):
Expand Down