[storage-preview] az storage account create: Rename --key-vault-federated-identity-client-id to --key-vault-federated-client-id
#4881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient-id` to `--key-vault-federated-client-id`
ghost
added
the
ghost
requested review from
evelyn-ys
commented
May 24, 2022
|
storage-preview |
…ys/azure-cli-extensions into storage_parameter_rename
evelyn-ys
commented
May 24, 2022
| @@ -211,97 +211,6 @@ def test_storage_account_resource_access_rules(self, resource_group, storage_acc | |||
| ]) | |||
|
|
|||
|
|
|||
| class FileServicePropertiesTests(StorageScenarioMixin, ScenarioTest): | |||
There was a problem hiding this comment.
Removed since it has been moved to CLI main repo
calvinhzy
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asked by storage PM to keep parameter name align with Powershell design
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az storage account createGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.