Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ConnectedMachine] bug fix: add enable-auto-upgrade param back to extension update command #4880

Merged
merged 21 commits into from
Jun 1, 2022

Conversation

dorothyhu
Copy link
Contributor

@dorothyhu dorothyhu commented May 23, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested a review from yonzhan May 23, 2022 23:21
@ghost ghost added the Auto-Assign Auto assign by bot label May 23, 2022
@ghost ghost requested a review from zhoxing-ms May 23, 2022 23:22
@ghost ghost assigned zhoxing-ms May 23, 2022
@ghost ghost added this to the Jun 2022 (2022-07-05) milestone May 23, 2022
@ghost ghost requested a review from wangzelin007 May 23, 2022 23:22
@yonzhan
Copy link
Collaborator

yonzhan commented May 23, 2022

ConnectedMachine

@dorothyhu
Copy link
Contributor Author

@zhoxing-ms @wangzelin007 Can you take a look at the pipeline integration tests? The tests ran successfully in local

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented May 26, 2022

FAIL: test_PrivateLinkAndPrivateEndpointConnection_Scenario (azext_connectedmachine.tests.latest.test_PrivateLinkAndPrivateEndpointConnection_scenario.PrivateLinkAndPrivateEndpointConnectionScenarioTest)
.......
No match for the request (<Request (PUT) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/az-sdk-test-000001/providers/Microsoft.Network/virtualNetworks/vnet-000001?api-version=2021-08-01>) was found.
Found 1 similar requests with 1 different matcher(s) :
1 - (<Request (PUT) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/az-sdk-test-000001/providers/Microsoft.Network/virtualNetworks/vnet-000001?api-version=2021-05-01>).
Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
Matchers failed :
_custom_request_query_matcher - assertion failure :
None

@dorothyhu This problem is caused by the upgrade of api-version for Microsoft.Network. Azure/azure-cli#22487
You need to pull the latest code from the remote dev branch from official CLI repo and re-record the recording yaml file of test_PrivateLinkAndPrivateEndpointConnection_Scenario in live mode, then push the re-recorded yaml file to the remote extension repo.

@zhoxing-ms
Copy link
Contributor

@dorothyhu Please pull the latest code from the remote dev branch from official CLI repo and re-record the recording yaml file. Please note that the expired code is your local official CLI code, not the CLI extension code

@dorothyhu
Copy link
Contributor Author

@zhoxing-ms I pulled the CLI repo and it fixed that Network issue. Can you check the CLI Linter error? I ran the command in local and it passed without errors

@zhoxing-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dorothyhu
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 4880 in repo Azure/azure-cli-extensions

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented May 30, 2022

This CLI linter issue is caused by the incorrect directory of the connectedmachine extension installed by CLI linter: the vendored_sdks path /src/ssh/azext_ssh/vendored_sdks/connectedmachine of ssh extension (introduced by PR #4570) is added.
Screenshot 2022-05-30 095740

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented May 30, 2022

The wrong path /src/ssh/azext_ssh/vendored_sdks/connectedmachine to add connectedmachine extension may be caused by the addition of setup.py file in PR #4570
@vthiebaut10 Please help remove the setup.py file in the vendored_sdks/connectedmachine

@vthiebaut10
Copy link
Contributor

@zhoxing-ms Just opened a PR to delete setup.py from /src/ssh/azext_ssh/vendored_sdks/connectedmachine: #4916
Let me know if it fixes the issue.

@zhoxing-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zhoxing-ms zhoxing-ms merged commit 33a77ae into Azure:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants