[feat] Add support for --assign-public-endpoint and --enable-log-stream-public-endpoint #4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
spring |
added 12 commits
May 21, 2022 23:41
zhoxing-ms
reviewed
May 26, 2022
src/spring/HISTORY.md
Outdated
Comment on lines
5
to
10
| * Command `az spring create` has new argument "--ingress-read-timeout" to set ingress read timeout when create Azure Spring App. | ||
| * Command `az spring update` has new argument "--ingress-read-timeout" to update ingress read timeout for Azure Spring App. | ||
| * Command `az spring create` has new argument "--enable-log-stream-public-endpoint" to set whether assign public endpoint for log streaming in vnet injection instance when create Azure Spring App. | ||
| * Command `az spring update` has new argument "--enable-log-stream-public-endpoint" to update whether assign public endpoint for log streaming in vnet injection instance for Azure Spring App. | ||
| * Command `az spring app create` has new argument "--assign_public_endpoint" to set whether assign endpoint URL which could be accessed out of virtual network for vnet injection instance app. | ||
| * Command `az spring app update` has new argument "--assign_public_endpoint" to update whether assign endpoint URL which could be accessed out of virtual network for vnet injection instance app. |
There was a problem hiding this comment.
It is suggested to merge some similar history notes, so that there will not be too much content for users to read
Suggested change
| * Command `az spring create` has new argument "--ingress-read-timeout" to set ingress read timeout when create Azure Spring App. | |
| * Command `az spring update` has new argument "--ingress-read-timeout" to update ingress read timeout for Azure Spring App. | |
| * Command `az spring create` has new argument "--enable-log-stream-public-endpoint" to set whether assign public endpoint for log streaming in vnet injection instance when create Azure Spring App. | |
| * Command `az spring update` has new argument "--enable-log-stream-public-endpoint" to update whether assign public endpoint for log streaming in vnet injection instance for Azure Spring App. | |
| * Command `az spring app create` has new argument "--assign_public_endpoint" to set whether assign endpoint URL which could be accessed out of virtual network for vnet injection instance app. | |
| * Command `az spring app update` has new argument "--assign_public_endpoint" to update whether assign endpoint URL which could be accessed out of virtual network for vnet injection instance app. | |
| * Command `az spring create/update` has new argument "--ingress-read-timeout" to set ingress read timeout when create Azure Spring App. | |
| * Command `az spring create/update` has new argument "--enable-log-stream-public-endpoint" to set whether assign public endpoint for log streaming in vnet injection instance when create Azure Spring App. | |
| * Command `az spring app create/update` has new argument "--assign_public_endpoint" to set whether assign endpoint URL which could be accessed out of virtual network for vnet injection instance app. |
zhoxing-ms
reviewed
May 26, 2022
| @@ -76,6 +76,10 @@ def load_arguments(self, _): | |||
| c.argument('service_runtime_subnet', arg_group='VNet Injection', options_list=['--service-runtime-subnet', '--svc-subnet'], help='The name or ID of an existing subnet in "vnet" into which to deploy the Spring Apps service runtime. Required when deploying into a Virtual Network.', validator=validate_vnet) | |||
| c.argument('service_runtime_network_resource_group', arg_group='VNet Injection', options_list=['--service-runtime-network-resource-group', '--svc-nrg'], help='The resource group where all network resources for Azure Spring Apps service runtime will be created in.', validator=validate_node_resource_group) | |||
| c.argument('app_network_resource_group', arg_group='VNet Injection', options_list=['--app-network-resource-group', '--app-nrg'], help='The resource group where all network resources for apps will be created in.', validator=validate_node_resource_group) | |||
| c.argument('enable_log_stream_public_endpoint', | |||
| arg_type=get_three_state_flag(), | |||
There was a problem hiding this comment.
Could we use action='store_true' instead of get_three_state_flag()?
There was a problem hiding this comment.
Seems could not, as this parameter would be persisted as properties of a resource
|
Could we add some scenario tests for those new parameters? |
|
Please address those conflicts |
Resolved |
I have added new scenario tests |
zhoxing-ms
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.