containerapp Version 0.3.4 Release #4794
Conversation
…#96) * Added tests. * Added recordings. Co-authored-by: Haroon Feisal <[email protected]>
ghost
requested a review
from 
ghost
added
the
Use Github repo's default branch for up and github actions
|
containerapp |
Cache GitHub credentials for 'az containerapp up' with --repo
StrawnSC
changed the title
* Change to use stable api version * More helpful error message when managedEnvironmentId is msising * Edit error message * Fix error message
* Finished label and revision work. * Finished dynamic weight update work. * Fixed small bug. * Added more items to revision table output. * Use patch instead of create or update API for traffic set. * Fixed small bug related to floats not rounding. * Added help. Updated resourcenotfounderror. Fixed existing bug related to no name given for revision command and latest passed. Added revision name inference from --revision to revision label add. * Fixed style. Co-authored-by: Haroon Feisal <[email protected]>
…n 2 characters. Seems to be an API issue.
`az containerapp up` -- only encrypt cached GitHub creds on windows
…id/azure-cli-extensions into may-11-2022-containerapp-release
Add back fileshares
| c.argument('traffic_weights', nargs='*', options_list=['--traffic-weight'], help="A list of revision weight(s) for the container app. Space-separated values in 'revision_name=weight' format. For latest revision, use 'latest=weight'") | ||
| c.argument('revision_weights', nargs='+', options_list=['--revision-weight'], help="A list of revision weight(s) for the container app. Space-separated values in 'revision_name=weight' format. For latest revision, use 'latest=weight'") |
There was a problem hiding this comment.
Could we use the deprecate_info flag to the traffic_weights parameter to set deprecation information first to avoid directly causing breaking change to users?
There was a problem hiding this comment.
@zhoxing-ms essentially this renamed to --revision-weight to reduce confusion with the new parameter --label-weight. To get around the need for a deprecation, I can add --traffic-weight as an option for --revision-weight
There was a problem hiding this comment.
I suggest using the deprecated_info for --traffic-weight if the --traffic-weight parameter is no longer recommended in the future, what do you think of it?
There was a problem hiding this comment.
Sounds good. I just added --traffic-weight as a deprecated argument option
|
@zhoxing-ms just made the two changes in response to your comments |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.