aks-preview: feature support for apiserver vnet integration #4787
Conversation
|
aks |
levimm
changed the title
|
wait for DRI to introduce 04-02 sdk. |
levimm
force-pushed
the
lima2/0505-swift
branch
2 times, most recently
from
68ade80 to
7920053
Compare
|
For the failure in AZCLI AKS UNIT TEST V2 - [AKS-PREVIEW], it complains missing test coverage for |
levimm
force-pushed
the
lima2/0505-swift
branch
2 times, most recently
from
c7f4a48 to
7741be9
Compare
levimm
force-pushed
the
lima2/0505-swift
branch
4 times, most recently
from
cc18445 to
f05ed64
Compare
| "Please use it together with --enable-private-cluster" | ||
| ) | ||
| if self.decorator_mode == DecoratorMode.UPDATE: | ||
| if enable_apiserver_vnet_integration: |
There was a problem hiding this comment.
do we need to validate if it is private cluster or not?
It is validated by rp right now, which means that is only nice to have. asking is because I see it in CREATE path but missed in UPDATE path.
There was a problem hiding this comment.
for the update, I don't think we need to pass the parameter --enable-private-cluster. And cli side cannot get existing mc so we cannot tell if it's private cluster or not at cli side.
There was a problem hiding this comment.
Actually, you could check if this is a private cluster with a helper function check_is_private_cluster (azure.cli.command_modules.acs._helpers.check_is_private_cluster). In an update scenario, the mc in the context is the "existing mc".
More details about "existing mc". To be honest, the current decorator does not record the original mc obtained by a GET at the beginning of the update command. The mc in the context is gradually updated with the update of each sub-profile, but I think it is impossible to modify whether a cluster is a private cluster through update? So you can use this "existing mc" to check directly.
The original mc will be preserved in the upcoming v2 decorator.
There was a problem hiding this comment.
Queued a pipeline to check the newly added case test_aks_create_with_apiserver_vnet_integration, works fine.
The PR looks good to me:shipit:
|
@zhoxing-ms Could you help merge this pr? |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.