Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error msg since secrets and env vars are space delimited #4593

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

calvinsID
Copy link
Contributor

@calvinsID calvinsID commented Mar 29, 2022

  • Small low hanging fruit I noticed: fix error msg since secrets and env vars are space delimited now, instead of comma delimited

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 29, 2022

containerapp

@calvinsID calvinsID merged commit 1f0ede5 into Azure:main Mar 30, 2022
@calvinsID calvinsID deleted the user/calcha/fix-error-msg branch March 30, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants