Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Refactor 6th part of the create sub-command in aks-preview module #4024

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Oct 26, 2021


This checklist is used to make sure that common guidelines for a pull request are followed.

  • Refactor windows profile to support gmsa related options

Unit Test Coverage:

  • "covered_lines": 344,
  • "num_statements": 370,
  • "percent_covered": 92.97297297297297,
  • "missing_lines": 26,
  • "excluded_lines": 0

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 26, 2021

AKS

@FumingZhang FumingZhang force-pushed the fuming/decorator-create-6 branch from 0ebd930 to 979bef6 Compare October 27, 2021 03:48
@FumingZhang FumingZhang marked this pull request as ready for review October 27, 2021 06:28
@zhoxing-ms zhoxing-ms merged commit 43ba3f5 into Azure:main Oct 27, 2021
@FumingZhang FumingZhang deleted the fuming/decorator-create-6 branch October 28, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants