Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jonathanhe/workload network #3910

Merged
merged 33 commits into from
Oct 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
722f956
added commands for workload-network dhcp
jonathanhe-msft Sep 8, 2021
b37281e
set limit of 3 on server_addresses and updated moved specific argumen…
jonathanhe-msft Sep 8, 2021
b1bbc2e
removed comments
jonathanhe-msft Sep 8, 2021
775dbb0
updated error type for server_messages validation
jonathanhe-msft Sep 9, 2021
38f86c9
removed comments and styling
jonathanhe-msft Sep 9, 2021
957199d
Merge branch 'main' into jonathanhe/workload-network
jonathanhe-msft Sep 10, 2021
31d213c
added dns-server commands
jonathanhe-msft Sep 10, 2021
abdeca0
added dns-zone commands
jonathanhe-msft Sep 14, 2021
834d297
allow dhcp server and relay calls with None parameters
jonathanhe-msft Sep 14, 2021
339bd77
Merge branch 'jonathanhe/workload-network' into jonathanhe/workload-n…
jonathanhe-msft Sep 14, 2021
99b4574
added workload_network dns-zone commands
jonathanhe-msft Sep 14, 2021
3c30cc1
Update src/vmware/CHANGELOG.md
zhoxing-ms Sep 15, 2021
9b2dec6
renamed dhcp test files to workload-network
jonathanhe-msft Sep 15, 2021
42bc120
merged with main
jonathanhe-msft Sep 15, 2021
0afef5f
Merge branch 'jonathanhe/workload-network' of https://github.com/jona…
jonathanhe-msft Sep 15, 2021
39708dc
added port-mirroring and renamed dhcp test file to workloadnetwork
jonathanhe-msft Sep 16, 2021
11f2334
updated changelog
jonathanhe-msft Sep 16, 2021
1b795ff
updated help and param text based on comments
jonathanhe-msft Sep 16, 2021
33c2876
fixed parameter typo
jonathanhe-msft Sep 21, 2021
c4616eb
workload-network segment public-ip and vm-group commands
jonathanhe-msft Sep 23, 2021
45baa66
merged with main
jonathanhe-msft Sep 23, 2021
9e84d8d
fixed merge issue
jonathanhe-msft Sep 23, 2021
4e13b13
updated merge
jonathanhe-msft Sep 23, 2021
d09f570
added workload-network vm and gateway commands'
jonathanhe-msft Sep 23, 2021
0813139
updated changelog
jonathanhe-msft Sep 23, 2021
37350bd
styling updates
jonathanhe-msft Sep 23, 2021
b566758
updated help texts
jonathanhe-msft Sep 23, 2021
18f8f64
Merge branch 'main' into jonathanhe/workload-network
jonathanhe-msft Sep 29, 2021
946973e
updated parameter name
jonathanhe-msft Sep 29, 2021
b71ae50
removed '-id' from parameters
jonathanhe-msft Oct 7, 2021
0a91334
Merge remote-tracking branch 'upstream/main' into jonathanhe/workload…
jonathanhe-msft Oct 7, 2021
f1ad9d3
fixed unit tests
jonathanhe-msft Oct 8, 2021
f4e0077
Merge branch 'main' into jonathanhe/workload-network
jonathanhe-msft Oct 8, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/vmware/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
- Add `az vmware workload-network dns-service` command group
- Add `az vmware workload-network dns-zone` command group
- Add `az vmware workload-network port-mirroring` command group
- Add `az vmware workload-network segment` command group
- Add `az vmware workload-network public-ip` command group
- Add `az vmware workload-network vm-group` command group
- Add `az vmware workload-network vm` command group
- Add `az vmware workload-network gateway` command group

## 3.1.0 (2021-08)

Expand Down
207 changes: 188 additions & 19 deletions src/vmware/azext_vmware/_help.py

Large diffs are not rendered by default.

34 changes: 30 additions & 4 deletions src/vmware/azext_vmware/_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def load_arguments(self, _):
c.argument('script_cmdlet_id', help='A reference to the script cmdlet resource if user is running a AVS script.')

with self.argument_context('vmware workload-network dhcp') as c:
c.argument('dhcp_id', help='NSX DHCP identifier. Generally the same as the DHCP display name.')
c.argument('dhcp', help='NSX DHCP identifier. Generally the same as the DHCP display name.')
c.argument('display_name', help='Display name of the DHCP entity.')
c.argument('revision', help='NSX revision number.')

Expand All @@ -150,7 +150,7 @@ def load_arguments(self, _):
c.argument('server_addresses', nargs='+', validator=server_addresses_length, help='DHCP Relay Addresses. Max 3.')

with self.argument_context('vmware workload-network dns-service') as c:
c.argument('dns_service_id', help="NSX DNS service identifier. Generally the same as the DNS service's display name.")
c.argument('dns_service', help="NSX DNS service identifier. Generally the same as the DNS service's display name.")
c.argument('display_name', help='Display name of the DNS service.')
c.argument('dns_service_ip', help='DNS service IP of the DNS service.')
c.argument('default_dns_zone', help='Default DNS zone of the DNS service.')
Expand All @@ -159,7 +159,7 @@ def load_arguments(self, _):
c.argument('revision', help='NSX revision number.')

with self.argument_context('vmware workload-network dns-zone') as c:
c.argument('dns_zone_id', help="NSX DNS zone identifier. Generally the same as the DNS zone's display name.")
c.argument('dns_zone', help="NSX DNS zone identifier. Generally the same as the DNS zone's display name.")
c.argument('display_name', help='Display name of the DNS zone.')
c.argument('domain', nargs='+', help='Domain names of the DNS zone.')
c.argument('dns_server_ips', nargs='+', help='DNS Server IP array of the DNS zone.')
Expand All @@ -168,9 +168,35 @@ def load_arguments(self, _):
c.argument('revision', help='NSX revision number.')

with self.argument_context('vmware workload-network port-mirroring') as c:
c.argument('port_mirroring_id', help="NSX Port Mirroring identifier. Generally the same as the Port Mirroring display name.")
c.argument('port_mirroring', help="NSX Port Mirroring identifier. Generally the same as the Port Mirroring display name.")
c.argument('display_name', help='Display name of the port mirroring profile.')
c.argument('direction', help='Direction of port mirroring profile. Possible values include: "INGRESS, EGRESS, BIDIRECTIONAL".')
c.argument('source', help='Source VM Group.')
c.argument('destination', help='Destination VM Group.')
c.argument('revision', help='NSX revision number.')

with self.argument_context('vmware workload-network segment') as c:
c.argument('segment', help="NSX Segment identifier. Generally the same as the Segment's display name.")
c.argument('display_name', help='Display name of the segment.')
c.argument('connected_gateway', help='Gateway which to connect segment to.')
c.argument('revision', help='NSX revision number.')
c.argument('dhcp_ranges', nargs='+', help='DHCP Range assigned for subnet.')
c.argument('gateway_address', help='Gateway address.')
c.argument('port_name', help='Name of port or VIF attached to segment.')

with self.argument_context('vmware workload-network public-ip') as c:
c.argument('public_ip', help="NSX Public IP Block identifier. Generally the same as the Public IP.")
c.argument('display_name', help='Display name of the Public IP Block.')
c.argument('number_of_public_ips', help='Number of Public IPs requested.')

with self.argument_context('vmware workload-network vm-group') as c:
c.argument('vm_group', help="NSX VM Group identifier. Generally the same as the VM Group's display name.")
c.argument('display_name', help='Display name of the VM group.')
c.argument('members', nargs='+', help='Virtual machine members of this group.')
c.argument('revision', help='NSX revision number.')

with self.argument_context('vmware workload-network vm') as c:
c.argument('virtual_machine', help="Virtual Machine identifier.")

with self.argument_context('vmware workload-network gateway') as c:
c.argument('gateway', help="NSX Gateway identifier. Generally the same as the Gateway's display name.")
28 changes: 28 additions & 0 deletions src/vmware/azext_vmware/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,3 +142,31 @@ def load_command_table(self, _):
g.custom_command('create', 'workload_network_port_mirroring_create')
g.custom_command('update', 'workload_network_port_mirroring_update')
g.custom_command('delete', 'workload_network_port_mirroring_delete')

with self.command_group('vmware workload-network segment', vmware_sdk, client_factory=cf_vmware) as g:
g.custom_command('list', 'workload_network_segment_list')
g.custom_show_command('show', 'workload_network_segment_get')
g.custom_command('create', 'workload_network_segment_create')
g.custom_command('update', 'workload_network_segment_update')
g.custom_command('delete', 'workload_network_segment_delete')

with self.command_group('vmware workload-network public-ip', vmware_sdk, client_factory=cf_vmware) as g:
g.custom_command('list', 'workload_network_public_ip_list')
g.custom_show_command('show', 'workload_network_public_ip_get')
g.custom_command('create', 'workload_network_public_ip_create')
g.custom_command('delete', 'workload_network_public_ip_delete')

with self.command_group('vmware workload-network vm-group', vmware_sdk, client_factory=cf_vmware) as g:
g.custom_command('list', 'workload_network_vm_group_list')
g.custom_show_command('show', 'workload_network_vm_group_get')
g.custom_command('create', 'workload_network_vm_group_create')
g.custom_command('update', 'workload_network_vm_group_update')
g.custom_command('delete', 'workload_network_vm_group_delete')

with self.command_group('vmware workload-network vm', vmware_sdk, client_factory=cf_vmware) as g:
g.custom_command('list', 'workload_network_vm_list')
g.custom_show_command('show', 'workload_network_vm_get')

with self.command_group('vmware workload-network gateway', vmware_sdk, client_factory=cf_vmware) as g:
g.custom_command('list', 'workload_network_gateway_list')
g.custom_show_command('show', 'workload_network_gateway_get')
Loading