Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SerialConsole] Change to require custom boot diagnostics #3737

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

adrianabedon
Copy link
Contributor


The following commands now check to see if the specified VM uses custom boot diagnostics.

az serial-console connect
az serial-console send nmi
az serial-console send sysrq
az serial-console send reset

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Aug 2, 2021
@ghost
Copy link

ghost commented Aug 2, 2021

Thank you for your contribution adrianabedon! We will review the pull request and get back to you soon.

@adrianabedon adrianabedon marked this pull request as ready for review August 2, 2021 19:12
@yonzhan yonzhan requested review from kairu-ms and jsntcy August 2, 2021 23:31
@yonzhan yonzhan added this to the Aug 2021 (2021-09-07) milestone Aug 2, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 2, 2021

SerialConsole

@kairu-ms kairu-ms merged commit 7db0d06 into Azure:main Aug 4, 2021
@adrianabedon adrianabedon deleted the serialconsole2 branch August 4, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants