Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Max CLI version for PostgreSQL and MySQL VNET extension #224

Closed
wants to merge 3 commits into from
Closed

Setting Max CLI version for PostgreSQL and MySQL VNET extension #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1d3dc2
Setting Max version for VNET extension
rahulgouthamDOTgs Jun 28, 2018
be11391
Re-uploading the wheel file
rahulgouthamDOTgs Jun 29, 2018
a1b1198
updating file name
rahulgouthamDOTgs Jun 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,10 +501,11 @@
],
"rdbms-vnet": [
{
"filename": "rdbms_vnet-10.0.0-py2.py3-none-any.whl",
"sha256Digest": "c10d63f21308751212b3bd68448b0dfe27d6e79bf9c54412680229f69f9bcec7",
"downloadUrl": "https://prodrdbmsclipackages.blob.core.windows.net/cliextensions/rdbms_vnet-10.0.0-py2.py3-none-any.whl",
"filename": "rdbms_vnet-10.0.1-py2.py3-none-any.whl",
Copy link
Contributor

@williexu williexu Jun 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the version number on line 544 below.
In addition, from the CI, it looks like your 'azext_metadata' isn't being packaged within your .whl file for some reason.

"sha256Digest": "c921b03f36e43f93d98caa060575845ecab0cdc98983731488d622f3edfd0c41",
"downloadUrl": "https://prodrdbmsclipackages.blob.core.windows.net/cliextensions/rdbms_vnet-10.0.1-py2.py3-none-any.whl",
"metadata": {
"azext.maxCliCoreVersion": "2.0.39",
"classifiers": [
"Development Status :: 4 - Beta",
"Intended Audience :: Developers",
Expand Down
3 changes: 2 additions & 1 deletion src/rdbms_vnet/azext_rdbms_vnet/azext_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{
"azext.minCliCoreVersion": "2.0.24"
"azext.minCliCoreVersion": "2.0.24",
"azext.maxCliCoreVersion": "2.0.39"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this extension not work on 2.0.40 and higher or is this functionality folded into the CLI in that version? If the later, then the right thing to do is annotate the CLI to supercede the extension:
https://github.com/Azure/azure-cli/blob/dev/doc/authoring_command_modules/authoring_commands.md#extension-suppression

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjprescott the extension commands have been added to the CLI module

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahulgouthamDOTgs made a PR to the cli repo suppressing the extensions in case a user has already installed the extension: Azure/azure-cli#6694

}
2 changes: 1 addition & 1 deletion src/rdbms_vnet/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from codecs import open
from setuptools import setup, find_packages

VERSION = "10.0.0"
VERSION = "10.0.1"

CLASSIFIERS = [
'Development Status :: 4 - Beta',
Expand Down