Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build extension command tree #2078

Merged
merged 10 commits into from
Jul 31, 2020

Conversation

fengzhou-msft
Copy link
Member

@fengzhou-msft fengzhou-msft commented Jul 28, 2020

Add scripts to build a command tree json for all extensions and upload to a storage account.

These scripts will be used in the release sync pipeline of extensions. Test pipeline: https://dev.azure.com/azure-sdk/internal/_build?definitionId=1857&_a=summary

The json file will be used in Azure CLI, related PR: Azure/azure-cli#14478

An example of the built file:

{
       "aks": {
               "create": "aks-preview",
               "update": "aks-preview",
               "app": {
                    "up": "deploy-to-azure"
               },
               "use-dev-spaces": "dev-spaces"
        },
        "blueprint": {
               "create":"blueprint",
               "update":"blueprint"
         },
        ...
}

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@haroldrandom
Copy link
Contributor

Who's going to need this?

@jiasli
Copy link
Member

jiasli commented Jul 29, 2020

I think the naming may cause confusion with the existing command index (Azure/azure-cli#13294).

@fengzhou-msft
Copy link
Member Author

I think the naming may cause confusion with the existing command index (Azure/azure-cli#13294).

How about the name command tree as it mimics a prefix tree?

@fengzhou-msft
Copy link
Member Author

Who's going to need this?

PR:Azure/azure-cli#14478 needs to search command in a json file for all extension commands and the json file is built in this PR.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 29, 2020

Trie tree solution is good and the performance is fast.

@fengzhou-msft fengzhou-msft changed the title Build extension command index Build extension command tree Jul 30, 2020
@fengzhou-msft fengzhou-msft merged commit 697b90e into Azure:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants