Add "Did You Mean This" Extension #1536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopher-o-toole
changed the title
|
ai |
christopher-o-toole
changed the title
jiasli
reviewed
May 12, 2020
Comment on lines
11
to
15
| with self.command_group('ai-did-you-mean-this') as g: | ||
| g.custom_command('version', 'show_extension_version') | ||
|
|
||
| with self.command_group('ai-did-you-mean-this', is_preview=True): | ||
| pass |
There was a problem hiding this comment.
Maybe combine them?
Suggested change
| with self.command_group('ai-did-you-mean-this') as g: | |
| g.custom_command('version', 'show_extension_version') | |
| with self.command_group('ai-did-you-mean-this', is_preview=True): | |
| pass | |
| with self.command_group('ai-did-you-mean-this', is_preview=True) as g: | |
| g.custom_command('version', 'show_extension_version') |
jiasli
reviewed
May 12, 2020
src/ai-did-you-mean-this/README.rst
Outdated
|
|
||
| Improve user experience by suggesting recovery options for common CLI failures. | ||
|
|
||
| This extension extends the default error handling behavior to include recommendations for recovery. Recommendations are based on how other users were successful after they encountered the same failure. |
There was a problem hiding this comment.
How about adding some instructions and usage scenarios? Like what kind of error can trigger this extension.
Comment on lines
20
to
26
| def should_enable_styling(): | ||
| try: | ||
| if sys.stdout.isatty(): | ||
| return True | ||
| except AttributeError: | ||
| pass | ||
| return False |
There was a problem hiding this comment.
Please also honor the no_color setting: Azure/azure-cli#12601
christopher-o-toole
requested review from
gtracer,
jsntcy,
Juliehzl,
kalyanaj,
mmyyrroonn,
qwordy,
temandr,
zikalino and
zqingqing1
as code owners
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New extension (in preview) which uses the Aladdin service to generate and show failure recovery recommendations on command failure. This extension makes use of the hook added to
parser.pyin CLI version2.4.0. For more information, see this CLI PR.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: