Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[containerapp] Being able to specify the Dockerfile name and the Docker build context in a containerapp up command #5041

Closed
agoncal opened this issue Jun 24, 2022 · 7 comments
Labels
Auto-Assign Auto assign by bot ContainerApp feature-request This issue requires a new behavior in the product in order be resolved. Service Attention This issue is responsible by Azure service team.

Comments

@agoncal
Copy link
Member

agoncal commented Jun 24, 2022

Related command

az containerapp up \
  --name villains-app \
  --environment "$CONTAINERAPPS_ENV" \
  --repo https://github.com/agoncal/villains-app \
  --resource-group "$RESOURCE_GROUP" \
  --location "$LOCATION" \
  --context-path src/main/docker 

Extension name (the extension in question)

containerapp

Description of issue (in as much detail as possible)

Today we can pass the context-path parameter to the up command to run a docker build specifying the location of the Dockerfile (if not it uses the defaults "./"). But in Java projects it is common to have several Docker files (e.g., to build a project in Java 11 as well as Java 17 and GraalVM).

Until 0.3.1 there was a docker-file-path parameter that got replaced with context-path. It would be great to have both attributes. So we could execute:

az containerapp up \
  --docker-file-path src/main/docker/Dockerfile.jvm11 
  --context-path . 

Or for consistency maybe prefix the attributes with docker so we could have:

az containerapp up \
  --docker-file-path src/main/docker/Dockerfile.jvm11 
  --docker-context-path . 

And of course, if no attribute is set, then the command goes back to the default Dockerfile name under ./

@ghost ghost added Auto-Assign Auto assign by bot ContainerApp CXP Attention This issue is handled by CXP team. labels Jun 24, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 24, 2022

route to CXP team

@PramodValavala-MSFT PramodValavala-MSFT added Service Attention This issue is responsible by Azure service team. feature-request This issue requires a new behavior in the product in order be resolved. and removed CXP Attention This issue is handled by CXP team. labels Jun 24, 2022
@PramodValavala-MSFT
Copy link
Contributor

@agoncal Looking at the code here, seems there is more to consider before supporting this. Transferring this to the concerning team.

@ghost
Copy link

ghost commented Jun 24, 2022

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @calvinsID.

Issue Details

Related command

az containerapp up \
  --name villains-app \
  --environment "$CONTAINERAPPS_ENV" \
  --repo https://github.com/agoncal/villains-app \
  --resource-group "$RESOURCE_GROUP" \
  --location "$LOCATION" \
  --context-path src/main/docker 

Extension name (the extension in question)

containerapp

Description of issue (in as much detail as possible)

Today we can pass the context-path parameter to the up command to run a docker build specifying the location of the Dockerfile (if not it uses the defaults "./"). But in Java projects it is common to have several Docker files (e.g., to build a project in Java 11 as well as Java 17 and GraalVM).

Until 0.3.1 there was a docker-file-path parameter that got replaced with context-path. It would be great to have both attributes. So we could execute:

az containerapp up \
  --docker-file-name src/main/docker/Dockerfile.jvm11 
  --context-path . 

Or for consistency maybe prefix the attributes with docker so we could have:

az containerapp up \
  --docker-file-name src/main/docker/Dockerfile.jvm11 
  --docker-context-path . 

And of course, if no attribute is set, then the command goes back to the default Dockerfile name under ./

Author: agoncal
Assignees: -
Labels:

Service Attention, feature-request, Auto-Assign, ContainerApp

Milestone: -

@agoncal
Copy link
Member Author

agoncal commented Jun 24, 2022

Oh, "GH actions API needs to be updated" ! Do you know if there is an issue related to this so we can keep track? #Thanks

@panchagnula
Copy link
Contributor

Currently we have no plans to add special parameters to up command, Adding @anthonychu & @sanchitmehta for JAVA specific scenarios support.

@panchagnula
Copy link
Contributor

Oh, "GH actions API needs to be updated" ! Do you know if there is an issue related to this so we can keep track? #Thanks

@agoncal please report regarding GitHub actions API support here https://github.com/microsoft/azure-container-apps/issues

@agoncal
Copy link
Member Author

agoncal commented Aug 9, 2022

Thanks

@agoncal agoncal closed this as completed Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp feature-request This issue requires a new behavior in the product in order be resolved. Service Attention This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

4 participants