connectedk8s upgrade cmd bug fix (#5411)

* Add security context to diagnoser container * version and history updates * fix proxy bug in connectedk8s upgrade * removed diagnoser change * removed extra space Co-authored-by: Siri Teja Reddy Kasireddy <[email protected]> Co-authored-by: Akash Keshari <[email protected]> Co-authored-by: siriteja <[email protected]>
Azure · Oct 3, 2022 · 901b97c · 901b97c
1 parent 54395df
commit 901b97c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/src/connectedk8s/HISTORY.rst b/src/connectedk8s/HISTORY.rst
@@ -2,6 +2,11 @@
 
 Release History
 ===============
+1.3.4
+++++++
+
+* Fixed a proxy related bug in connectedk8s upgrade
+
 1.3.3
 ++++++
 

diff --git a/src/connectedk8s/azext_connectedk8s/custom.py b/src/connectedk8s/azext_connectedk8s/custom.py
@@ -1232,6 +1232,7 @@ def upgrade_agents(cmd, client, resource_group_name, cluster_name, kube_config=N
             if key == "global.isProxyEnabled":
                 proxy_enabled_param_added = True
             if (key == "global.httpProxy" or key == "global.httpsProxy" or key == "global.noProxy"):
+                value = escape_proxy_settings(value)
                 if value and not proxy_enabled_param_added:
                     cmd_helm_upgrade.extend(["--set", "global.isProxyEnabled={}".format(True)])
                     proxy_enabled_param_added = True

diff --git a/src/connectedk8s/setup.py b/src/connectedk8s/setup.py
@@ -17,7 +17,7 @@
 # TODO: Confirm this is the right version number you want and it matches your
 # HISTORY.rst entry.
 
-VERSION = '1.3.3'
+VERSION = '1.3.4'
 
 # The full list of classifiers is available at
 # https://pypi.python.org/pypi?%3Aaction=list_classifiers
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,11 @@ @@
     Release History
     ===============
+.3.4
+    ++++++
+    * Fixed a proxy related bug in connectedk8s upgrade
 .3.3
     ++++++
@@ Expand Down @@