Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support data disks #34

Closed
Klaas- opened this issue Feb 16, 2022 · 3 comments · Fixed by #35
Closed

Support data disks #34

Klaas- opened this issue Feb 16, 2022 · 3 comments · Fixed by #35

Comments

@Klaas-
Copy link

Klaas- commented Feb 16, 2022

Hi,
currently it does not seem to be able to recognize azurerm_managed_disk and azurerm_virtual_machine_data_disk_attachment resources in azure

Greetings
Klaas

@magodo
Copy link
Collaborator

magodo commented Feb 17, 2022

@Klaas- Thank you for submitting this!

For the azurerm_managed_disk is not supported, I assume you mean you didn't see it is auto filled in the resource list. This is because the tool didn't recognize this API path as a azurerm_managed_disk (for this specific case, it is fixed in #35). In this case, you can manually identify the resource type and fill in with azurerm_managed_disk.

For the azurerm_virtual_machine_data_disk_attachment, due to it is an association/attachment resource, currently it is not well supported by the tool (see the limitation). Please follow issue #3 for any progress.

@Klaas-
Copy link
Author

Klaas- commented Feb 17, 2022

I did not see the managed disks at all in the resource selection, maybe I need to compile from dev branch? I was using version 0.0.6

About the attachment: there is a 1/1 resource association for normal managed disks, it's not like a shared disk that gets attached to multiple resources. That's why I assumed the limitation does not apply here :)

@magodo
Copy link
Collaborator

magodo commented Feb 17, 2022

@Klaas- Yes, you'll need to install the latest one. Just run: go install github.com/Azure/aztfy@latest.

For the association, I mean from the API model, there is actually no such resource called azurerm_virtual_machine_data_disk_attachment in Azure, it is actually modeled as a property in the VM's model. The abstraction is introduced by terraform only, usally for better user experience. So no matter the disk is associated with one or multiple VMs, as long as it is some abstraction of terraform, I'll call them association resource. To support these kinds of resources need additional effort, especially need to follow up when the provider evolves. Due to the workload needed, currently we are still on hold to add the support for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants