Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AZQR result files resource type mismatch ? #274

Open
joufflu1 opened this issue Nov 26, 2024 · 3 comments · May be fixed by #276
Open

AZQR result files resource type mismatch ? #274

joufflu1 opened this issue Nov 26, 2024 · 3 comments · May be fixed by #276
Assignees
@cmendible
Labels
bug Something isn't working

Comments

@joufflu1
Copy link

Expected Behavior

In result files, for VMs storage, Microsoft.Compute/disks type may be used instead of Microsoft.Compute/virtualMachines in "impacted" file/tab

Actual Behavior

AZQR version : azqr version 2.0.3-preview.0.3
Environment : WSL2

AZQR result files (csv and xlsx) seems to provide the following mismatch :

In "Inventory" file/tab, Disks are identified as Microsoft.Compute/disks whereas in "Impacted", the same resources are identified as Microsoft.Compute/virtualMachines resource type.

(Maybe the type was filled with ManagedBy information instead of Resource type ?)

Steps to Reproduce the Problem

Scan a resource group where Disks do not follow this recommendation : Use Azure Disks with Zone Redundant Storage for higher resiliency and availability and compare the used resource type in Inventory and Impacted files/tabs.

Thanks for your help,
Regards,
David
@cmendible
Copy link
Member

Hi there, can you confirm that the recommendation id is: fa0cf4f5-0b21-47b7-89a9-ee936f193ce1

@cmendible cmendible added the bug Something isn't working label Nov 26, 2024
@cmendible cmendible self-assigned this Nov 26, 2024
@joufflu1
Copy link
Author

Hi,

I confirm it is this recommandation ID.

cmendible added a commit that referenced this issue Dec 10, 2024
@cmendible
feat: updated aprl to add disk scanning, fixes #274
b825a5d
@cmendible cmendible linked a pull request Dec 10, 2024 that will close this issue
Open
3 tasks
@cmendible
Copy link
Member

This was caused by a mismatch in the aprl source code which has been fixed. Can you please try the binary from here and let me know if it works for you: https://github.com/Azure/azqr/actions/runs/12253479963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmendible cmendible

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: updated aprl to add disk scanning, fixes #274 Azure/azqr
2 participants
@cmendible @joufflu1