New rule: The items property for Schema Objects, or schema-like objects (non-body parameters), MUST be required when type is set to array

[veronicagg]

 M2042: The items property for Schema Objects, or schema-like objects (non-body parameters), MUST be required when type is set to array. More details can be found at OAI/OpenAPI-Specification#174.
Category: SDK Violation
Severity: Warning

[dsgouda]

Wondering if this can be an error.

[veronicagg]

@dsgouda what impact does it have if the type is not set to array?

[dsgouda]

Tried generating CSharp client using AutoRest with a model property of type without "items" defined, AutoRest throws an exception.
We can still keep this validation rule just to warn the user.
@veronicagg thoughts?
@fearthecowboy do you think we should make AutoRest consider some sort of a default when the "items" is not defined for "array" type

[veronicagg]

@dsgouda if autorest decides to implement a default, then I wouldn't implement the rule.
If autorest does not implement a default, we can implement this rule as a SDK Violation error, since not following the rule prevents code generation.
Thanks!

[veronicagg]

Azure/azure-openapi-validator#8

[dsgouda]

Merged, pending publishing of new validator package