Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscriptionId is not a required parameter in all operations samples #1864

Closed
kazrael2119 opened this issue May 22, 2023 · 0 comments · Fixed by #1869
Closed

subscriptionId is not a required parameter in all operations samples #1864

kazrael2119 opened this issue May 22, 2023 · 0 comments · Fixed by #1869
Assignees
@qiaozha
Labels
Epic: Generate tests and samples https://github.com/Azure/cadl-azure/issues/1946 Mgmt This issue is related to a management-plane library.

Comments

@kazrael2119
Copy link
Contributor

issue:Azure/azure-sdk-for-js#25857

Azure/azure-sdk-for-js#25889 (comment)
in swagger , there is no subscriptionId parameter.
And after my test, this operation can work well without sending subscriptionId in client level.

we can fix it to enhance the customer experience， create an issue to track this
@kazrael2119 kazrael2119 mentioned this issue May 22, 2023
Merged
@qiaozha qiaozha changed the title subscriptionId is not a required parameter in all operations subscriptionId is not a required parameter in all operations samples May 22, 2023
@qiaozha qiaozha added Mgmt This issue is related to a management-plane library. Epic: Generate tests and samples https://github.com/Azure/cadl-azure/issues/1946 labels May 22, 2023
@qiaozha qiaozha mentioned this issue May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qiaozha qiaozha

Labels
Epic: Generate tests and samples https://github.com/Azure/cadl-azure/issues/1946 Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make subscirption id optional if there're tenant level operations qiaozha/autorest.typescript
2 participants
@qiaozha @kazrael2119