Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPG] do not generate maxpagesize on client operations #1314

Closed
kristapratico opened this issue Jun 20, 2022 · 4 comments · Fixed by #1320
Closed

[DPG] do not generate maxpagesize on client operations #1314

kristapratico opened this issue Jun 20, 2022 · 4 comments · Fixed by #1320
Assignees

Comments

@kristapratico
Copy link
Member

According to @johanste, this parameter should not be accessible at the client operation-level. We should instead accept this kwarg on the ItemPaged.by_page().

@johanste
Copy link
Member

Correctamundo. I think that it should be a safe assumption that any parameter that matches maxpagesize (with or without a leading '$' sign, and case insensitive) should be folded into the pageable code generation.

@johanste
Copy link
Member

On a related note, @iscai-msft, are morphing conditional requests (e.g. if-match and friends) into the corresponding well-known parameters in our DPG code gen?

@iscai-msft
Copy link
Contributor

Sorry I don't quite get your last question. If your last question is "are we special casing any parameters into well-known locations", we aren't really right now

@johanste
Copy link
Member

We should be. In the fullness of time. In the short term, we can do swagger transforms. But we want to make things go on autopilot/not needing any human intervention for these kind of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants