Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client, public EnvironmentsClientBuilder pipeline(HttpPipeline pipeline) { #1765

Closed
weidongxu-microsoft opened this issue Oct 14, 2022 · 0 comments · Fixed by #2155
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. DPG MQ This issue is part of a "milestone of quality" initiative.

Comments

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Oct 14, 2022

Azure/azure-sdk-for-java#31300 (comment)

for pipeline and httpClient we should update this to copy what the hand-written builders do with logging a debug message if the HttpPipeline, or HttpClient, is set to null after being configured as there is a chance that it is a bug in user code:

if (this.pipeline != null && pipeline == null) {
    logger.info("HttpPipeline is being set to 'null' when it was previously configured.");
}
@weidongxu-microsoft weidongxu-microsoft added Client This issue points to a problem in the data-plane of the library. MQ This issue is part of a "milestone of quality" initiative. DPG labels Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. DPG MQ This issue is part of a "milestone of quality" initiative.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants