Conditionally set Content-Type header #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the body param is optional, the Content-Type header should be set IFF the body param is not nil. Don't expose optional Content-Type literal params as flags.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@benbp part of the PR has been consistently failing with error "fatal: couldn't find remote ref refs/pull/1456/merge". Have you seen this before? This originally was passing. I restarted it as the CLA check was stuck. |
chlowell
approved these changes
Oct 29, 2024
|
@jhendrixMSFT not sure, though looks like you did get a passing CI run eventually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the body param is optional, the Content-Type header should be set IFF the body param is not nil.
Don't expose optional Content-Type literal params as flags.
Fixes #1444