Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Models deemed unused are not public / no setters and manually customizing is non-trivial #1048

Open
chamons opened this issue Feb 23, 2021 · 0 comments
Open

Models deemed unused are not public / no setters and manually customizing is non-trivial #1048

chamons opened this issue Feb 23, 2021 · 0 comments
Assignees
@chamons
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. v3 Version 3 of AutoRest C# generator.

Comments

@chamons
Copy link
Contributor

chamons commented Feb 23, 2021

In Azure/azure-sdk-for-net#18848 and Azure/azure-sdk-for-net#18515 a lot of customization was done to make the models public and have setters.

Initial research suggests autorest.csharp believed these types were not important and generated the code internal/read only because of that.

We should look into improving this, likely by passing hints, to make this customization easier.
@chamons chamons added the v3 Version 3 of AutoRest C# generator. label Feb 23, 2021
@chamons chamons added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chamons chamons

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. v3 Version 3 of AutoRest C# generator.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chamons